Skip to content

Provide more descriptive error message when there is a duplicate line… #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itdependsnetworks merged 1 commit into from
Jun 27, 2024
Merged

Provide more descriptive error message when there is a duplicate line… #539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion netutils/config/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,14 @@ def _update_same_line_children_configs(self) -> None:
new_config_lines: t.List[ConfigLine] = []
for line in self.config_lines:
if line in self.same_line_children:
previous_line = new_config_lines[-1]
try:
previous_line = new_config_lines[-1]
except IndexError as error:
raise IndexError(
f"This error is likely from a duplicate line detected at the line `{line.config_line}`, "
"see https://netutils.readthedocs.io/en/latest/dev/dev_config/#duplicate-line-detection "
f"for more details.\nOriginal Error: {error}"
)
previous_config_line = previous_line.config_line
current_parents = previous_line.parents + (previous_config_line,)
line = ConfigLine(line.config_line, current_parents)
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,14 @@ def test_incorrect_banner_ios():
)
with pytest.raises(ValueError):
compliance.parser_map["cisco_ios"](banner_cfg).config_lines # pylint: disable=expression-not-assigned


def test_duplicate_line():
logging = (
"!\n"
"snmp-server community <<REPLACED>> RO SNMP_ACL_RO\n"
"snmp-server community <<REPLACED>> RO SNMP_ACL_RO\n"
"snmp-server community <<REPLACED>> RW SNMP_ACL_RW\n"
)
with pytest.raises(IndexError, match=r".*This error is likely from a duplicate line detected.*"):
compliance.parser_map["cisco_ios"](logging).config_lines # pylint: disable=expression-not-assigned