Skip to content

Commit 17699d0

Browse files
susnuxsusnux
committed
fix: Update psalm baseline
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 9e01675 commit 17699d0

File tree

3 files changed

+81
-75
lines changed

3 files changed

+81
-75
lines changed

‎psalm.xml‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
<?xml version="1.0"?>
22
<psalm
3-
errorLevel="4"
4-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5-
xmlns="https://getpsalm.org/schema/config"
6-
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
7-
errorBaseline="tests/psalm-baseline.xml"
3+
errorLevel="4"
4+
phpVersion="8.0"
5+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
6+
xmlns="https://getpsalm.org/schema/config"
7+
xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
8+
errorBaseline="tests/psalm-baseline.xml"
89
>
910
<stubs>
1011
<file name="tests/stub.phpstub" preloadClasses="true"/>

‎tests/psalm-baseline.xml‎

Lines changed: 69 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,21 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="4.29.0@7ec5ffbd5f68ae03782d7fd33fff0c45a69f95b3">
3-
<file src="lib/Activity/Provider.php">
4-
<ParamNameMismatch occurrences="1">
5-
<code>$lang</code>
6-
</ParamNameMismatch>
7-
</file>
8-
<file src="lib/Activity/ProviderParser.php">
9-
<InvalidNullableReturnType occurrences="1">
10-
<code>array&lt;string,string|integer&gt;</code>
11-
</InvalidNullableReturnType>
12-
<NullableReturnStatement occurrences="1">
13-
<code>null</code>
14-
</NullableReturnStatement>
15-
<UndefinedMethod occurrences="1">
16-
<code>Circles::generateAbsoluteLink($circle-&gt;getUniqueId())</code>
17-
</UndefinedMethod>
18-
</file>
2+
<files psalm-version="4.30.0@d0bc6e25d89f649e4f36a534f330f8bb4643dd69">
193
<file src="lib/AppInfo/Application.php">
20-
<UndefinedClass occurrences="1">
21-
<code>OCA\Files\App</code>
22-
</UndefinedClass>
4+
<InvalidArgument occurrences="8">
5+
<code>registerEventListener</code>
6+
<code>registerEventListener</code>
7+
<code>registerEventListener</code>
8+
<code>registerEventListener</code>
9+
<code>registerEventListener</code>
10+
<code>registerEventListener</code>
11+
<code>registerEventListener</code>
12+
<code>registerEventListener</code>
13+
</InvalidArgument>
14+
</file>
15+
<file src="lib/AppInfo/Capabilities.php">
16+
<LessSpecificImplementedReturnType occurrences="1">
17+
<code>array</code>
18+
</LessSpecificImplementedReturnType>
2319
</file>
2420
<file src="lib/Circles/FileSharingBroadcaster.php">
2521
<InvalidScalarArgument occurrences="2">
@@ -37,28 +33,29 @@
3733
<code>$this-&gt;federationNotifications</code>
3834
<code>Notifications</code>
3935
</UndefinedDocblockClass>
40-
<UndefinedInterfaceMethod occurrences="4">
36+
<UndefinedInterfaceMethod occurrences="1">
4137
<code>getLazyRootFolder</code>
42-
<code>setHtmlBody</code>
43-
<code>setPlainBody</code>
44-
<code>setSubject</code>
4538
</UndefinedInterfaceMethod>
4639
</file>
47-
<file src="lib/CirclesManager.php">
48-
<InvalidNullableReturnType occurrences="1">
49-
<code>IFederatedUser</code>
50-
</InvalidNullableReturnType>
51-
<NullableReturnStatement occurrences="1">
52-
<code>$this-&gt;federatedUserService-&gt;getCurrentUser()</code>
53-
</NullableReturnStatement>
54-
</file>
5540
<file src="lib/Command/CirclesCheck.php">
5641
<UndefinedClass occurrences="2">
5742
<code>AppConfig</code>
43+
<code>AppConfig</code>
5844
</UndefinedClass>
5945
</file>
60-
<file src="lib/Command/CirclesRemote.php">
46+
<file src="lib/Command/CirclesList.php">
6147
<UndefinedMethod occurrences="1">
48+
<code>section</code>
49+
</UndefinedMethod>
50+
</file>
51+
<file src="lib/Command/CirclesMemberships.php">
52+
<UndefinedMethod occurrences="1">
53+
<code>section</code>
54+
</UndefinedMethod>
55+
</file>
56+
<file src="lib/Command/CirclesRemote.php">
57+
<UndefinedMethod occurrences="2">
58+
<code>section</code>
6259
<code>setType</code>
6360
</UndefinedMethod>
6461
</file>
@@ -78,6 +75,12 @@
7875
<TypeDoesNotContainNull occurrences="1">
7976
<code>$owner === null</code>
8077
</TypeDoesNotContainNull>
78+
<UndefinedClass occurrences="1">
79+
<code>Process</code>
80+
</UndefinedClass>
81+
<UndefinedMethod occurrences="1">
82+
<code>section</code>
83+
</UndefinedMethod>
8184
</file>
8285
<file src="lib/Command/MembersAdd.php">
8386
<UndefinedMethod occurrences="1">
@@ -94,6 +97,22 @@
9497
<code>getStatus</code>
9598
<code>hasInvitedBy</code>
9699
</UndefinedInterfaceMethod>
100+
<UndefinedMethod occurrences="1">
101+
<code>section</code>
102+
</UndefinedMethod>
103+
</file>
104+
<file src="lib/Command/MembersSearch.php">
105+
<UndefinedMethod occurrences="1">
106+
<code>section</code>
107+
</UndefinedMethod>
108+
</file>
109+
<file src="lib/Command/SharesFiles.php">
110+
<UndefinedClass occurrences="1">
111+
<code>MissingInputException</code>
112+
</UndefinedClass>
113+
<UndefinedMethod occurrences="1">
114+
<code>section</code>
115+
</UndefinedMethod>
97116
</file>
98117
<file src="lib/Command/SyncContact.php">
99118
<InvalidReturnType occurrences="1">
@@ -218,11 +237,6 @@
218237
<code>!$sendPasswordByMail</code>
219238
<code>$sendPasswordByMail</code>
220239
</TypeDoesNotContainType>
221-
<UndefinedInterfaceMethod occurrences="3">
222-
<code>setHtmlBody</code>
223-
<code>setPlainBody</code>
224-
<code>setSubject</code>
225-
</UndefinedInterfaceMethod>
226240
</file>
227241
<file src="lib/GlobalScale/FileUnshare.php">
228242
<ParamNameMismatch occurrences="1">
@@ -250,11 +264,6 @@
250264
<ParamNameMismatch occurrences="1">
251265
<code>$mustBeChecked</code>
252266
</ParamNameMismatch>
253-
<UndefinedInterfaceMethod occurrences="3">
254-
<code>setHtmlBody</code>
255-
<code>setPlainBody</code>
256-
<code>setSubject</code>
257-
</UndefinedInterfaceMethod>
258267
</file>
259268
<file src="lib/GlobalScale/MemberJoin.php">
260269
<InvalidScalarArgument occurrences="1">
@@ -431,8 +440,8 @@
431440
</file>
432441
<file src="lib/Model/ShareWrapper.php">
433442
<InvalidArgument occurrences="2">
443+
<code>$attributes</code>
434444
<code>Cache::cacheEntryFromData($this-&gt;getFileCache()-&gt;toCache(), OC::$server-&gt;getMimeTypeLoader())</code>
435-
<code>$this-&gt;setAttributes($attributes)</code>
436445
</InvalidArgument>
437446
<InvalidNullableReturnType occurrences="5">
438447
<code>Circle</code>
@@ -515,8 +524,12 @@
515524
<code>$bookId</code>
516525
<code>$bookId</code>
517526
</InvalidScalarArgument>
518-
<UndefinedClass occurrences="1">
527+
<UndefinedClass occurrences="5">
519528
<code>CardDavBackend</code>
529+
<code>GenericEvent</code>
530+
<code>GenericEvent</code>
531+
<code>GenericEvent</code>
532+
<code>GenericEvent</code>
520533
</UndefinedClass>
521534
<UndefinedDocblockClass occurrences="6">
522535
<code>$this-&gt;cardDavBackend</code>
@@ -528,21 +541,20 @@
528541
</UndefinedDocblockClass>
529542
</file>
530543
<file src="lib/Service/EventsService.php">
531-
<InvalidArgument occurrences="2">
532-
<code>$context</code>
533-
<code>new GenericEvent(null, $arguments)</code>
534-
</InvalidArgument>
544+
<UndefinedClass occurrences="2">
545+
<code>EventDispatcher</code>
546+
<code>GenericEvent</code>
547+
</UndefinedClass>
548+
<UndefinedDocblockClass occurrences="2">
549+
<code>$this-&gt;eventDispatcher</code>
550+
<code>EventDispatcher</code>
551+
</UndefinedDocblockClass>
535552
</file>
536553
<file src="lib/Service/FederatedShareService.php">
537554
<InvalidMethodCall occurrences="1">
538555
<code>gObj</code>
539556
</InvalidMethodCall>
540557
</file>
541-
<file src="lib/Service/FederatedUserService.php">
542-
<InvalidReturnType occurrences="1">
543-
<code>FederatedUser</code>
544-
</InvalidReturnType>
545-
</file>
546558
<file src="lib/Service/GSDownstreamService.php">
547559
<UndefinedMethod occurrences="7">
548560
<code>asyncBroadcast</code>
@@ -572,7 +584,6 @@
572584
<code>getGlobalScaleEvent</code>
573585
<code>getGlobalScaleEvent</code>
574586
<code>getInstances</code>
575-
<code>getInstances</code>
576587
<code>getKey</code>
577588
</UndefinedMethod>
578589
</file>
@@ -631,13 +642,6 @@
631642
<code>$signed === null</code>
632643
</TypeDoesNotContainNull>
633644
</file>
634-
<file src="lib/Service/SendMailService.php">
635-
<UndefinedInterfaceMethod occurrences="3">
636-
<code>setHtmlBody</code>
637-
<code>setPlainBody</code>
638-
<code>setSubject</code>
639-
</UndefinedInterfaceMethod>
640-
</file>
641645
<file src="lib/Service/SyncService.php">
642646
<InvalidClass occurrences="2">
643647
<code>federatedEventService</code>
@@ -705,15 +709,15 @@
705709
</TooManyArguments>
706710
</file>
707711
<file src="lib/Tools/Traits/TNCLogger.php">
712+
<RedundantCondition occurrences="1">
713+
<code>isset($this-&gt;logger) &amp;&amp; $this-&gt;logger instanceof LoggerInterface</code>
714+
</RedundantCondition>
708715
<RedundantPropertyInitializationCheck occurrences="1">
709716
<code>isset($this-&gt;logger)</code>
710717
</RedundantPropertyInitializationCheck>
711718
<UndefinedClass occurrences="1">
712719
<code>HintException</code>
713720
</UndefinedClass>
714-
<RedundantCondition occurrences="1">
715-
<code>isset($this->logger)</code>
716-
</RedundantCondition>
717721
</file>
718722
<file src="lib/Tools/Traits/TNCRequest.php">
719723
<InvalidArgument occurrences="1">
@@ -733,9 +737,4 @@
733737
<code>$s[$e]</code>
734738
</InvalidArrayOffset>
735739
</file>
736-
<file src="lib/Listeners/AccountUpdated.php">
737-
<RedundantCondition occurrences="1">
738-
<code>$event instanceof UserUpdatedEvent</code>
739-
</RedundantCondition>
740-
</file>
741740
</files>

‎tests/stub.phpstub‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ declare(strict_types=1);
2121
*
2222
*/
2323

24+
namespace OCA\Files\Event {
25+
class LoadAdditionalScriptsEvent extends \OCP\EventDispatcher\Event {
26+
//
27+
}
28+
}
29+
2430
namespace OCA\Files_Trashbin\Trash {
2531
use OCP\Files\Node;
2632
use OCP\Files\Storage\IStorage;

0 commit comments

Comments
 (0)