Skip to content

Commit 471fd99

Browse files
Merge pull request #2561 from nextcloud/feat/lint-info-xml
Create lint-info-xml.yml
2 parents 02cd0d2 + 778dde6 commit 471fd99

File tree

2 files changed

+48
-19
lines changed

2 files changed

+48
-19
lines changed
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# This workflow is provided via the organization template repository
2+
#
3+
# https://github.com/nextcloud/.github
4+
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
5+
6+
name: Lint
7+
8+
on:
9+
pull_request:
10+
push:
11+
branches:
12+
- master
13+
- stable*
14+
15+
jobs:
16+
xml-linters:
17+
runs-on: ubuntu-latest
18+
19+
name: info.xml lint
20+
steps:
21+
- name: Checkout
22+
uses: actions/checkout@master
23+
24+
- name: Download schema
25+
run: wget https://raw.githubusercontent.com/nextcloud/appstore/master/nextcloudappstore/api/v1/release/info.xsd
26+
27+
- name: Lint info.xml
28+
uses: ChristophWurst/xmllint-action@v1
29+
with:
30+
xml-file: ./appinfo/info.xml
31+
xml-schema-file: ./info.xsd

appinfo/info.xml

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<?xml version="1.0"?>
2-
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance"
3-
xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
2+
<info xmlns:xsi= "http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://apps.nextcloud.com/schema/apps/info.xsd">
43
<id>contacts</id>
54
<name>Contacts</name>
65
<summary>A contacts app for Nextcloud</summary>
@@ -18,12 +17,16 @@
1817
<author>John Molakvoæ</author>
1918
<author>Team Popcorn</author>
2019

20+
<!-- required for dav plugins registration -->
21+
<types>
22+
<dav/>
23+
</types>
24+
2125
<documentation>
2226
<user>https://docs.nextcloud.com/server/stable/user_manual/en/pim/contacts.html</user>
2327
<admin>https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/occ_command.html?highlight=occ%20commands#dav-label</admin>
2428
<developer>https://github.com/nextcloud/contacts#build-the-app</developer>
2529
</documentation>
26-
<screenshot>https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Contacts/contacts.png</screenshot>
2730

2831
<category>office</category>
2932
<category>social</category>
@@ -32,20 +35,20 @@
3235
<website>https://github.com/nextcloud/contacts#readme</website>
3336
<bugs>https://github.com/nextcloud/contacts/issues</bugs>
3437
<repository type="git">https://github.com/nextcloud/contacts.git</repository>
35-
36-
<!-- required for dav plugins registration -->
37-
<types>
38-
<dav/>
39-
</types>
38+
<screenshot>https://raw.githubusercontent.com/nextcloud/screenshots/master/apps/Contacts/contacts.png</screenshot>
4039

4140
<dependencies>
4241
<php min-version="7.3" max-version="8.0" />
4342
<nextcloud min-version="21" max-version="24" />
4443
</dependencies>
4544

46-
<contactsmenu>
47-
<provider>OCA\Contacts\ContactsMenu\Providers\DetailsProvider</provider>
48-
</contactsmenu>
45+
<background-jobs>
46+
<job>OCA\Contacts\Cron\SocialUpdateRegistration</job>
47+
</background-jobs>
48+
49+
<settings>
50+
<admin>OCA\Contacts\Settings\AdminSettings</admin>
51+
</settings>
4952

5053
<navigations>
5154
<navigation>
@@ -56,12 +59,7 @@
5659
</navigation>
5760
</navigations>
5861

59-
<background-jobs>
60-
<job>OCA\Contacts\Cron\SocialUpdateRegistration</job>
61-
</background-jobs>
62-
63-
<settings>
64-
<admin>OCA\Contacts\Settings\AdminSettings</admin>
65-
</settings>
66-
62+
<contactsmenu>
63+
<provider>OCA\Contacts\ContactsMenu\Providers\DetailsProvider</provider>
64+
</contactsmenu>
6765
</info>

0 commit comments

Comments
 (0)