Skip to content

Commit e8cd9dc

Browse files
committed
fixup! Add indices on various columns to increase performance
1 parent 90369ad commit e8cd9dc

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

tests/psalm-baseline.xml

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,6 @@
6666
<code>Command</code>
6767
</UndefinedClass>
6868
</file>
69-
<file src="lib/Command/RepairMailTheads.php">
70-
<UndefinedClass occurrences="1">
71-
<code>Command</code>
72-
</UndefinedClass>
73-
</file>
7469
<file src="lib/Command/SyncAccount.php">
7570
<UndefinedClass occurrences="1">
7671
<code>Command</code>
@@ -88,7 +83,7 @@
8883
</file>
8984
<file src="lib/Db/AliasMapper.php">
9085
<ImplicitToStringCast occurrences="1">
91-
<code>$qb2-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
86+
<code>$qb2-&gt;createParameter('ids')</code>
9287
</ImplicitToStringCast>
9388
</file>
9489
<file src="lib/Db/CollectedAddressMapper.php">
@@ -98,7 +93,7 @@
9893
</file>
9994
<file src="lib/Db/MailboxMapper.php">
10095
<ImplicitToStringCast occurrences="1">
101-
<code>$qb2-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
96+
<code>$qb2-&gt;createParameter('ids')</code>
10297
</ImplicitToStringCast>
10398
</file>
10499
<file src="lib/Db/MessageMapper.php">
@@ -122,12 +117,12 @@
122117
<code>$qb-&gt;createParameter('ids')</code>
123118
<code>$qb-&gt;createParameter('uids')</code>
124119
<code>$qb-&gt;createParameter('uids')</code>
125-
<code>$qb2-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
126-
<code>$qb2-&gt;createNamedParameter(array_keys($indexedMessages), IQueryBuilder::PARAM_INT_ARRAY)</code>
127-
<code>$qb4-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
120+
<code>$qb2-&gt;createParameter('ids')</code>
121+
<code>$qb2-&gt;createParameter('ids')</code>
122+
<code>$qb4-&gt;createParameter('ids')</code>
128123
<code>$query-&gt;createParameter('ids')</code>
129-
<code>$select-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
130-
<code>$select-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
124+
<code>$select-&gt;createParameter('ids')</code>
125+
<code>$select-&gt;createParameter('ids')</code>
131126
</ImplicitToStringCast>
132127
<InvalidReturnStatement occurrences="1">
133128
<code>$update-&gt;execute()</code>
@@ -149,8 +144,8 @@
149144
</file>
150145
<file src="lib/Db/TagMapper.php">
151146
<ImplicitToStringCast occurrences="4">
152-
<code>$deleteQB-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
153-
<code>$deleteQB-&gt;createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code>
147+
<code>$deleteQB-&gt;createParameter('ids')</code>
148+
<code>$deleteQB-&gt;createParameter('ids')</code>
154149
<code>$qb-&gt;createParameter('ids')</code>
155150
<code>$qb-&gt;createParameter('ids')</code>
156151
</ImplicitToStringCast>
@@ -294,8 +289,9 @@
294289
<UndefinedClass occurrences="1">
295290
<code>PostgreSQL94Platform</code>
296291
</UndefinedClass>
297-
<UndefinedDocblockClass occurrences="1">
298-
<code>\Doctrine\DBAL\Exception</code>
292+
<UndefinedDocblockClass occurrences="2">
293+
<code>\Doctrine\DBAL\Exception</code>
294+
<code>\Doctrine\DBAL\Platforms\AbstractPlatform</code>
299295
</UndefinedDocblockClass>
300296
<UndefinedInterfaceMethod occurrences="1">
301297
<code>getDatabasePlatform</code>
@@ -333,6 +329,14 @@
333329
<code>SaveDraftEvent</code>
334330
</MissingDependency>
335331
</file>
332+
<file src="lib/Service/Provisioning/Manager.php">
333+
<UndefinedDocblockClass occurrences="4">
334+
<code>\OCP\DB\Exception</code>
335+
<code>\OCP\DB\Exception</code>
336+
<code>\OCP\DB\Exception</code>
337+
<code>\OCP\DB\Exception</code>
338+
</UndefinedDocblockClass>
339+
</file>
336340
<file src="lib/Service/Sync/ImapToDbSynchronizer.php">
337341
<MissingDependency occurrences="4">
338342
<code>NewMessagesSynchronized</code>

0 commit comments

Comments
 (0)