Skip to content

Commit 028ca09

Browse files
committed
Don't redirect when loading files index page
Currently we are redirecting from ?dir=/&fileid=2 to ?dir=/. This is an issue because we then need to load two pages with full file system setup and authentification instead of one and the assets won't start loading until the second page is delivered to the user. Additionally when loading ?dir=/, we then change the url back to ?dir=/&fileid=2 (without reload) so that the next time we load the page again we do the same thing again. Depending on the speed of the server and internet connection we can save 100ms to 400ms, improving the user experience. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
1 parent fbbbc2e commit 028ca09

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

apps/files/lib/Controller/ViewController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ public function showFile(string $fileid = null, int $openfile = 1): Response {
184184
* @throws NotFoundException
185185
*/
186186
public function index($dir = '', $view = '', $fileid = null, $fileNotFound = false, $openfile = null) {
187-
if ($fileid !== null) {
187+
if ($fileid !== null && $dir === '') {
188188
try {
189189
return $this->redirectToFile($fileid);
190190
} catch (NotFoundException $e) {

0 commit comments

Comments
 (0)