Merge pull request #19932 from nextcloud/remove-placeholder-check

remove the requirement that everything that looks like a placeholder …

Author: rullzer

apps/files_external/lib/config.php

@@ -252,20 +252,6 @@ public static function getBackendStatus($class, $options, $isPersonal, $testOnly
 				continue;
 			}
 			$option = self::substitutePlaceholdersInConfig($option);
-			if(!self::arePlaceholdersSubstituted($option)) {
-				\OC::$server->getLogger()->error(
-					'A placeholder was not substituted: {option} for mount type {class}',
-					[
-						'app' => 'files_external',
-						'option' => $option,
-						'class' => $class,
-					]
-				);
-				throw new StorageNotAvailableException(
-					'Mount configuration incomplete',
-					StorageNotAvailableException::STATUS_INCOMPLETE_CONF
-				);
-			}
 		}
 		if (class_exists($class)) {
 			try {
@@ -290,20 +276,6 @@ public static function getBackendStatus($class, $options, $isPersonal, $testOnly
 		return StorageNotAvailableException::STATUS_ERROR;
 	}
 
-	public static function arePlaceholdersSubstituted($option):bool {
-		$result = true;
-		if(is_array($option)) {
-			foreach ($option as $optionItem) {
-				$result = $result && self::arePlaceholdersSubstituted($optionItem);
-			}
-		} else if (is_string($option)) {
-			if (strpos(rtrim($option, '$'), '$') !== false) {
-				$result = false;
-			}
-		}
-		return $result;
-	}
-
 	/**
 	 * Read the mount points in the config file into an array
 	 *