Fix: Check if $this->params['user'] is an array

william-p · william-p · commit 3178352eebf1 · 2019-02-04T17:31:51.000+01:00
diff --git a/lib/private/Files/ObjectStore/SwiftFactory.php b/lib/private/Files/ObjectStore/SwiftFactory.php
@@ -122,7 +122,7 @@ private function getClient() {
 			'handler' => HandlerStack::create()
 		]);
 
-		if (isset($this->params['user']) && isset($this->params['user']['name'])) {
+		if (isset($this->params['user']) && is_array($this->params['user']) && isset($this->params['user']['name'])) {
 			if (!isset($this->params['scope'])) {
 				throw new StorageAuthException('Scope has to be defined for V3 requests');
 			}

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ private function getClient() {`
`122`	`122`	`'handler' => HandlerStack::create()`
`123`	`123`	`]);`
`124`	`124`
`125`		`- if (isset($this->params['user']) && isset($this->params['user']['name'])) {`
	`125`	`+ if (isset($this->params['user']) && is_array($this->params['user']) && isset($this->params['user']['name'])) {`
`126`	`126`	`if (!isset($this->params['scope'])) {`
`127`	`127`	`throw new StorageAuthException('Scope has to be defined for V3 requests');`
`128`	`128`	`}`