Skip to content

Commit 386eac0

Browse files
committed
fix: Only show share permission if re-sharable
Signed-off-by: nfebe <fenn25.fn@gmail.com>
1 parent 11df08f commit 386eac0

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

apps/files_sharing/src/views/SharingDetailsTab.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@
195195
data-cy-files-sharing-share-permissions-checkbox="update">
196196
{{ t('files_sharing', 'Edit') }}
197197
</NcCheckboxRadioSwitch>
198-
<NcCheckboxRadioSwitch v-if="config.isResharingAllowed && share.type !== ShareType.Link"
198+
<NcCheckboxRadioSwitch v-if="resharingIsPossible"
199199
:disabled="!canSetReshare"
200200
:checked.sync="canReshare"
201201
data-cy-files-sharing-share-permissions-checkbox="share">
@@ -556,6 +556,9 @@ export default {
556556
return t('files_sharing', 'Update share')
557557
558558
},
559+
resharingIsPossible() {
560+
return this.config.isResharingAllowed && this.share.type !== ShareType.Link && this.share.type !== ShareType.Email
561+
},
559562
/**
560563
* Can the sharer set whether the sharee can edit the file ?
561564
*
@@ -705,7 +708,7 @@ export default {
705708
[ATOMIC_PERMISSIONS.DELETE]: this.t('files_sharing', 'Delete'),
706709
}
707710
708-
return [ATOMIC_PERMISSIONS.READ, ATOMIC_PERMISSIONS.CREATE, ATOMIC_PERMISSIONS.UPDATE, ATOMIC_PERMISSIONS.SHARE, ATOMIC_PERMISSIONS.DELETE]
711+
return [ATOMIC_PERMISSIONS.READ, ATOMIC_PERMISSIONS.CREATE, ATOMIC_PERMISSIONS.UPDATE, ...(this.resharingIsPossible ? [ATOMIC_PERMISSIONS.SHARE] : []), ATOMIC_PERMISSIONS.DELETE]
709712
.filter((permission) => hasPermissions(this.share.permissions, permission))
710713
.map((permission, index) => index === 0
711714
? translatedPermissions[permission]

0 commit comments

Comments
 (0)