Skip to content

Commit 4785fae

Browse files
authored
Merge pull request #14809 from nextcloud/fix/accessibility-theme-keyboard
Fix selecting an accessibility theme with the keyboard
2 parents 8432583 + 6a5f081 commit 4785fae

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

apps/accessibility/js/accessibility.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/accessibility/js/accessibility.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/accessibility/src/components/itemPreview.vue

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
<div class="preview-description">
55
<h3>{{preview.title}}</h3>
66
<p>{{preview.text}}</p>
7-
<input type="checkbox" class="checkbox" :id="'accessibility-' + preview.id" :checked="selected === preview.id" />
8-
<label :for="'accessibility-' + preview.id" @click="selectItem">{{t('accessibility', 'Enable')}} {{preview.title.toLowerCase()}}</label>
7+
<input type="checkbox" class="checkbox" :id="'accessibility-' + preview.id" v-model="checked" @change="selectItem" />
8+
<label :for="'accessibility-' + preview.id">{{t('accessibility', 'Enable')}} {{preview.title.toLowerCase()}}</label>
99
</div>
1010
</div>
1111
</template>
@@ -14,12 +14,16 @@
1414
export default {
1515
name: 'itemPreview',
1616
props: ['preview', 'selected'],
17+
data() {
18+
return {
19+
checked: this.selected === this.preview.id,
20+
};
21+
},
1722
methods: {
1823
selectItem() {
1924
this.$emit(
2025
'select',
21-
// if we clicked the already selected one: disable it
22-
this.preview.id === this.selected ? false : this.preview.id
26+
this.checked ? this.preview.id : false
2327
);
2428
}
2529
}

0 commit comments

Comments
 (0)