Merge pull request #9073 from nextcloud/backport/9070/guessing_without_target_is_useles-13

rullzer · web-flow · commit 656df69cf04b · 2018-04-11T00:36:07.000+02:00
[stable13] When formatting a share node an Empty target is invalid
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -147,7 +147,7 @@ protected function formatShare(\OCP\Share\IShare $share, Node $recipientNode = n
 			if (empty($nodes)) {
 				// fallback to guessing the path
 				$node = $userFolder->get($share->getTarget());
-				if ($node === null) {
+				if ($node === null || $share->getTarget() === '') {
 					throw new NotFoundException();
 				}
 			} else {

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ protected function formatShare(\OCP\Share\IShare $share, Node $recipientNode = n`
`147`	`147`	`if (empty($nodes)) {`
`148`	`148`	`// fallback to guessing the path`
`149`	`149`	`$node = $userFolder->get($share->getTarget());`
`150`		`- if ($node === null) {`
	`150`	`+ if ($node === null \|\| $share->getTarget() === '') {`
`151`	`151`	`throw new NotFoundException();`
`152`	`152`	`}`
`153`	`153`	`} else {`