Skip to content

Commit 7c4a7a7

Browse files
committed
improve notify tests for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
1 parent 31af141 commit 7c4a7a7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

apps/files_external/tests/Storage/SmbTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public function testNotifyGetChanges() {
122122
];
123123

124124
foreach ($expected as $expectedChange) {
125-
$this->assertContains($expectedChange, $changes, 'Actual changes are:' . PHP_EOL . print_r($expected, true), false, false); // dont check object identity
125+
$this->assertContains($expectedChange, $changes, "Expected changes are:\n" . print_r($expected, true) . "\nGot:\n" . print_r($changes, true), false, false); // dont check object identity
126126
}
127127
}
128128

@@ -135,7 +135,7 @@ public function testNotifyListen() {
135135

136136
$result = null;
137137

138-
// since the notify handler buffers untill we start listening we will get the above changes
138+
// since the notify handler buffers until we start listening we will get the above changes
139139
$notifyHandler->listen(function (IChange $change) use (&$result) {
140140
$result = $change;
141141
return false;//stop listening

0 commit comments

Comments
 (0)