Allow more chars in metadata keys

artonge · artonge · commit 926c0d2646b0 · 2023-11-02T17:05:25.000+01:00
Signed-off-by: Louis Chemineau &lt;louis@chmn.me&gt;
diff --git a/lib/private/FilesMetadata/Model/FilesMetadata.php b/lib/private/FilesMetadata/Model/FilesMetadata.php
@@ -490,11 +490,11 @@ public function removeStartsWith(string $keyPrefix): IFilesMetadata {
 	 * @throws FilesMetadataKeyFormatException
 	 */
 	private function confirmKeyFormat(string $key): void {
-		if (ctype_alnum(str_replace('-', '', $key))) {
+		if (ctype_alnum(str_replace(['-', '_'], '', $key))) {
 			return;
 		}
 
-		throw new FilesMetadataKeyFormatException('key can only contains alphanumerical characters, and dash (-)');
+		throw new FilesMetadataKeyFormatException('key can only contains alphanumerical characters, and dash (-, _)');
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -490,11 +490,11 @@ public function removeStartsWith(string $keyPrefix): IFilesMetadata {`
`490`	`490`	`* @throws FilesMetadataKeyFormatException`
`491`	`491`	`*/`
`492`	`492`	`private function confirmKeyFormat(string $key): void {`
`493`		`- if (ctype_alnum(str_replace('-', '', $key))) {`
	`493`	`+ if (ctype_alnum(str_replace(['-', '_'], '', $key))) {`
`494`	`494`	`return;`
`495`	`495`	`}`
`496`	`496`
`497`		`- throw new FilesMetadataKeyFormatException('key can only contains alphanumerical characters, and dash (-)');`
	`497`	`+ throw new FilesMetadataKeyFormatException('key can only contains alphanumerical characters, and dash (-, _)');`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`/**`