Skip to content

Commit a86c113

Browse files
authored
Merge pull request #44869 from nextcloud/fix/systemtags-input-label
fix(systemtags): Use built-in input label to satisfy a11y check of NcSelect
2 parents 4988f0d + 07525af commit a86c113

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

apps/systemtags/src/components/SystemTags.vue

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@
2626
:name="t('systemtags', 'Loading collaborative tags …')"
2727
:size="32" />
2828
<template v-else>
29-
<label for="system-tags-input">{{ t('systemtags', 'Search or create collaborative tags') }}</label>
3029
<NcSelectTags class="system-tags__select"
31-
input-id="system-tags-input"
30+
:input-label="t('systemtags', 'Search or create collaborative tags')"
3231
:placeholder="t('systemtags', 'Collaborative tags …')"
3332
:options="sortedTags"
3433
:value="selectedTags"
@@ -224,10 +223,7 @@ export default Vue.extend({
224223
display: flex;
225224
flex-direction: column;
226225
227-
label[for="system-tags-input"] {
228-
margin-bottom: 2px;
229-
}
230-
226+
// Fix issue with AppSidebar styles overwriting NcSelect styles
231227
&__select {
232228
width: 100%;
233229
:deep {

dist/files-sidebar.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/files-sidebar.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)