Merge pull request #23935 from nextcloud/backport/23921/stable20

MorrisJobke · web-flow · commit f8b550dab7ca · 2020-11-06T22:24:31.000+01:00
[stable20] Fix casting of integer and boolean on Oracle
diff --git a/lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php b/lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
@@ -170,6 +170,10 @@ public function castColumn($column, $type) {
 			$column = $this->helper->quoteColumnName($column);
 			return new QueryFunction('to_char(' . $column . ')');
 		}
+		if ($type === IQueryBuilder::PARAM_INT || $type === IQueryBuilder::PARAM_BOOL) {
+			$column = $this->helper->quoteColumnName($column);
+			return new QueryFunction('to_number(to_char(' . $column . '))');
+		}
 
 		return parent::castColumn($column, $type);
 	}

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,10 @@ public function castColumn($column, $type) {`
`170`	`170`	`$column = $this->helper->quoteColumnName($column);`
`171`	`171`	`return new QueryFunction('to_char(' . $column . ')');`
`172`	`172`	`}`
	`173`	`+ if ($type === IQueryBuilder::PARAM_INT \|\| $type === IQueryBuilder::PARAM_BOOL) {`
	`174`	`+ $column = $this->helper->quoteColumnName($column);`
	`175`	`+ return new QueryFunction('to_number(to_char(' . $column . '))');`
	`176`	`+ }`
`173`	`177`
`174`	`178`	`return parent::castColumn($column, $type);`
`175`	`179`	`}`