Fix potential empty result

nickvergessen · nickvergessen · commit fcdbd4eca365 · 2021-01-20T10:11:56.000+01:00
Signed-off-by: Joas Schilling &lt;coding@schilljs.com&gt;
diff --git a/apps/files_external/lib/Listener/StorePasswordListener.php b/apps/files_external/lib/Listener/StorePasswordListener.php
@@ -51,9 +51,9 @@ public function handle(Event $event): void {
 		}
 
 		$stored = $this->credentialsManager->retrieve($event->getUser()->getUID(), LoginCredentials::CREDENTIALS_IDENTIFIER);
-		$update = $stored['password'] !== $event->getPassword();
+		$update = isset($stored['password']) && $stored['password'] !== $event->getPassword();
 		if (!$update && $event instanceof UserLoggedInEvent) {
-			$update = $stored['user'] !== $event->getLoginName();
+			$update = isset($stored['user']) && $stored['user'] !== $event->getLoginName();
 		}
 
 		if ($stored && $update) {

Original file line number	Diff line number	Diff line change
`@@ -51,9 +51,9 @@ public function handle(Event $event): void {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`$stored = $this->credentialsManager->retrieve($event->getUser()->getUID(), LoginCredentials::CREDENTIALS_IDENTIFIER);`
`54`		`- $update = $stored['password'] !== $event->getPassword();`
	`54`	`+ $update = isset($stored['password']) && $stored['password'] !== $event->getPassword();`
`55`	`55`	`if (!$update && $event instanceof UserLoggedInEvent) {`
`56`		`- $update = $stored['user'] !== $event->getLoginName();`
	`56`	`+ $update = isset($stored['user']) && $stored['user'] !== $event->getLoginName();`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`if ($stored && $update) {`