lib/private/User: add reminder to first change 'enabled' property, then issue event

Leon Klingele · Leon Klingele · commit fcfa7de18091 · 2019-03-06T13:14:29.000+01:00
A new event, 'preChangeUser', should be used for this instead. See #14565.
diff --git a/lib/private/User/User.php b/lib/private/User/User.php
@@ -365,6 +365,7 @@ public function setEnabled(bool $enabled = true) {
 		$oldStatus = $this->isEnabled();
 		$this->enabled = $enabled;
 		if ($oldStatus !== $this->enabled) {
+			// TODO: First change the value, then trigger the event as done for all other properties.
 			$this->triggerChange('enabled', $enabled, $oldStatus);
 			$this->config->setUserValue($this->uid, 'core', 'enabled', $enabled ? 'true' : 'false');
 		}

Original file line number	Diff line number	Diff line change
`@@ -365,6 +365,7 @@ public function setEnabled(bool $enabled = true) {`
`365`	`365`	`$oldStatus = $this->isEnabled();`
`366`	`366`	`$this->enabled = $enabled;`
`367`	`367`	`if ($oldStatus !== $this->enabled) {`
	`368`	`+ // TODO: First change the value, then trigger the event as done for all other properties.`
`368`	`369`	`$this->triggerChange('enabled', $enabled, $oldStatus);`
`369`	`370`	`$this->config->setUserValue($this->uid, 'core', 'enabled', $enabled ? 'true' : 'false');`
`370`	`371`	`}`