Skip to content

Commit fe30653

Browse files
danxuliurullzer
authored andcommitted
Fix "checkWellKnownUrl" not being run
The check is run only if its last parameter is true; data() tries to convert the HTML attribute string to an actual JavaScript value, so "true" is returned as an actual boolean instead of an string; as a strict comparison against "true" was used the result was false and thus the checks were not run. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
1 parent c759a78 commit fe30653

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

settings/js/admin.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,8 @@ $(document).ready(function(){
248248
// run setup checks then gather error messages
249249
$.when(
250250
OC.SetupChecks.checkWebDAV(),
251-
OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === 'true'),
252-
OC.SetupChecks.checkWellKnownUrl('/.well-known/carddav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === 'true'),
251+
OC.SetupChecks.checkWellKnownUrl('/.well-known/caldav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true),
252+
OC.SetupChecks.checkWellKnownUrl('/.well-known/carddav/', oc_defaults.docPlaceholderUrl, $('#postsetupchecks').data('check-wellknown') === true),
253253
OC.SetupChecks.checkSetup(),
254254
OC.SetupChecks.checkGeneric(),
255255
OC.SetupChecks.checkDataProtected()

0 commit comments

Comments
 (0)