Skip to content

fix(f2v): Files list loading with special chars in uid #40313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pytal wants to merge 2 commits into from
Closed

fix(f2v): Files list loading with special chars in uid #40313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a157932
fix: Files list loading with special chars in uid
Pytal Sep 7, 2023
c8ce525
chore: Compile assets
Pytal Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/files/src/services/WebdavClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export const rootPath = `/files/${getCurrentUser()?.uid}`
export const defaultRootUrl = generateRemoteUrl('dav' + rootPath)

export const getClient = (rootUrl = defaultRootUrl) => {
const client = createClient(rootUrl, {
// Encode valid user id characters
const encodedUrl = encodeURI(rootUrl)
.replaceAll('\'', '%27')
Copy link
Member

@skjnldsv skjnldsv Sep 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have to replace quotes, they are allowed in an URL according to rfc2396

I think the webdav have an issue. Here are the exact two same requests:

Without quote in userId With quote in userId
2023-09-08_09-13 image

const client = createClient(encodedUrl, {
headers: {
requesttoken: getRequestToken() || '',
},
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.