Allow social sharing to specify if a new window is opened#4409
Merged
MorrisJobke merged 1 commit intomasterfrom Apr 20, 2017
Merged
Allow social sharing to specify if a new window is opened#4409MorrisJobke merged 1 commit intomasterfrom
MorrisJobke merged 1 commit intomasterfrom
Conversation
For example mail shares should not open a new window because it looks weird. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
LukasReschke,
MorrisJobke,
nickvergessen and
schiessle
ChristophWurst
added
4. to release
Codecov Report
@@ Coverage Diff @@
## master #4409 +/- ##
=========================================
Coverage ? 54.15%
Complexity ? 21630
=========================================
Files ? 1328
Lines ? 82781
Branches ? 1312
=========================================
Hits ? 44828
Misses ? 37953
Partials ? 0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For nextcloud/socialsharing#5
For example mail shares should not open a new window because it looks
weird.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl