Skip to content

Fix problem if process.stageOutMode = 'move'#332

Closed
Lehmann-Fabian wants to merge 2 commits intonf-core:devfrom
Lehmann-Fabian:dev
Closed

Fix problem if process.stageOutMode = 'move'#332
Lehmann-Fabian wants to merge 2 commits intonf-core:devfrom
Lehmann-Fabian:dev

Conversation

@Lehmann-Fabian
Copy link
Member

@Lehmann-Fabian Lehmann-Fabian commented Jan 25, 2023

Using process.stageOutMode = 'move' will only move files that match the output from a temporary directory to the working directory. Here, it breaks the symlink ${prefix}.bam -> $bam as only ${prefix}.bam is moved, creating a dead link.
Defining path(bam) as output solves this problem.

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
Signed-off-by: Lehmann_Fabian <fabian.lehmann@informatik.hu-berlin.de>
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are already staged here and are made available here, so there is no need to merge this change, I'd say

@JoseEspinosa
Copy link
Member

The files are already staged here and are made available here, so there is no need to merge this change, I'd say

Will close now ☝️
Feel free to reopen it if you think is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants