Wrapper for using requireJS as JSLoader

[tokafew420]

jsLoader callback param expects err as the first argument, but require()
has separate callbacks for success and error. Create a wrapper to
resolve conflict. Also add jsLoader.requirejs property for loaders.core
to determine filetype and errors
fixes #178

[ocombe]

Hmm it looks like the requirejs example isn't working anymore with this merged :-/

[ocombe]

OK I fixed it, not sure why there was a bind(null, null), but it works without it.

[tokafew420]

Sorry this is my fault, the callback should be bound to like so, callback.bind(null,undefined).
Binding the first argument to null causes the error checking to return a false positive because of the angular.isDefined:

if (angular.isDefined(err) && ($delegate.jsLoader.hasOwnProperty("ocLazyLoadLoader") || $delegate.jsLoader.hasOwnProperty("requirejs")))

The "callback.bind(null, undefined)" is so that the callback passed to jsLoader() is called correctly by requirejs . The Nodejs callback convention is callback(err, vaue, ..)but requirejs expects 2 separate callbacks, one for defined values callback(value, ...) and another for error callback(err). Without the binding, when require-ing a define() module, the callback will be called with the return of the define() and the promise (jsDefered) is rejected.

Also, if may be better to not use angular.isDefined(err) in the case that null is passed as the error, as is usually done with nodejs callbacks. Perhaps something like this:

if (err && ($delegate.jsLoader.hasOwnProperty("ocLazyLoadLoader") || $delegate.jsLoader.hasOwnProperty("requirejs")))

[ocombe]

You're right :)
Any chance to get a new PR with this fix ?

[tokafew420]

I submitted PR #264 for the success callback binding.

I thought about updating the callback error checking mentioned above thinking that angularjs has isNullOrUndefined() [or something similar] but there isn't. I didn't want to litter the source with angular.isDefine() && err !== null as this seems better suited for a utility function.