Skip to content

Commit 7e3d7d8

Browse files
authored
Silhouette should return None (#1770)
1 parent 63679db commit 7e3d7d8

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

river/metrics/silhouette.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def _find_distance_second_closest_center(centers, x):
7070

7171
def update(self, x, y_pred, centers, w=1.0):
7272
if y_pred not in centers or len(centers) < 2:
73-
return self
73+
return
7474

7575
distance_closest_centroid = utils.math.minkowski_distance(centers[y_pred], x, 2)
7676
self._sum_distance_closest_centroid += distance_closest_centroid
@@ -80,7 +80,7 @@ def update(self, x, y_pred, centers, w=1.0):
8080

8181
def revert(self, x, y_pred, centers, w=1.0):
8282
if y_pred not in centers or len(centers) < 2:
83-
return self
83+
return
8484

8585
distance_closest_centroid = utils.math.minkowski_distance(centers[y_pred], x, 2)
8686
self._sum_distance_closest_centroid -= distance_closest_centroid

0 commit comments

Comments
 (0)