fix: Fix dimension mismatch in active evaluation metric

[burhansavci]

Fixes #678

[gemini-code-assist]

Summary of Changes

Hello @burhansavci, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a dimension mismatch problem within the active evaluation metric by modifying the MetricsHook to proactively include flag metadata dimensions during the BeforeAsync stage. This change ensures that the set of dimensions for metrics remains consistent throughout the evaluation lifecycle, preventing issues that could arise from differing tag structures between the initial and final hook calls.

Highlights

• Metric Dimension Consistency: The MetricsHook now ensures that flag metadata dimensions are consistently added to evaluation metrics during the BeforeAsync hook, even when the metadata is not yet available.
• Graceful Null Handling: The AddFlagMetadataDimensions method is now called in BeforeAsync with a null flag metadata, ensuring that the metric tags are initialized with the correct dimensions, even if their values are null, preventing dimension mismatch.
• New Test Coverage: Two new tests have been added to validate that metric tags remain consistent between the BeforeAsync and FinallyAsync phases, and that null flag metadata is handled correctly during the BeforeAsync hook.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a dimension mismatch issue in the active evaluation metric by ensuring flag metadata dimensions are included in the BeforeAsync hook, using null values since the metadata isn't available at that stage. This change ensures tag key consistency between the BeforeAsync and FinallyAsync hooks for the UpDownCounter, which is the correct approach. The accompanying new tests are well-designed, verifying that the tag keys match and that null values are handled gracefully. The changes are solid, and I have one minor suggestion to enhance the readability of one of the new tests.

[askpt]

Thanks for reporting and fixing it @burhansavci. LGTM!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (dcd6649) to head (8f65af6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files          69       69           
  Lines        2993     2994    +1     
  Branches      359      359           
=======================================
+ Hits         2790     2791    +1     
  Misses        143      143           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.