Skip to content

#24288: fix the glossary list having deleted glossary after the delete action #24688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ashish8689 wants to merge 10 commits into
base: main
Choose a base branch
from
Open

#24288: fix the glossary list having deleted glossary after the delete action #24688

Ashish8689 wants to merge 10 commits into from
+796 −4

Conversation

@Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Dec 4, 2025 •
edited by siddhant1
Loading

Describe your changes:

Fixes #24288

  • fix the glossary list having deleted glossary after the delete action
  • If the delete fails, we call the deleteFailed callback
  • for glossary page the delete fail callback is refetch glossaries page
  • Added Unit tests
  • Added e2e specs
Screen.Recording.2025-12-04.at.12.56.23.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 self-assigned this Dec 4, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner December 4, 2025 07:26
@Ashish8689 Ashish8689 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 64% (50500/78908) 41.43% (24430/58965) 44.96% (7726/17183)

@karanh37
Copy link
Contributor

karanh37 commented Dec 8, 2025

cc - @siddhant1 for tests

@siddhant1 siddhant1 removed the To release Will cherry-pick this PR into the release branch label Dec 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 10, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@siddhant1 siddhant1

@Ashish8689 Ashish8689

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deleted Glossary Remains Visible in Navigation Pane

4 participants

@Ashish8689 @karanh37 @siddhant1