[Code health] include-what-you-use cleanup (#2692)

Author: marcalff

.github/workflows/iwyu.yml

@@ -38,6 +38,7 @@ jobs:
           CC="clang" CXX="clang++" cmake \
             -DCMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-w;-Xiwyu;--mapping_file=${TOPDIR}/.iwyu.imp;" \
             -DBUILD_TESTING=OFF \
+            -DWITH_DEPRECATED_SDK_FACTORY=OFF \
             -DBUILD_W3CTRACECONTEXT_TEST=OFF \
             ..
 

CHANGELOG.md

@@ -24,6 +24,9 @@ Increment the:
 * [API/SDK] Provider cleanup
   [#2664](https://github.com/open-telemetry/opentelemetry-cpp/pull/2664)
 
+* [Code health] include-what-you-use cleanup
+  [#2692](https://github.com/open-telemetry/opentelemetry-cpp/pull/2692)
+
 Important changes:
 
 * [API/SDK] Provider cleanup

api/include/opentelemetry/nostd/type_traits.h

@@ -15,7 +15,7 @@
 #  include <type_traits>
 
 #  include "opentelemetry/config.h"
-#  include "opentelemetry/nostd/detail/void.h"
+#  include "opentelemetry/nostd/detail/void.h"  // IWYU pragma: export
 #  include "opentelemetry/version.h"
 
 OPENTELEMETRY_BEGIN_NAMESPACE

api/include/opentelemetry/nostd/utility.h

@@ -15,8 +15,8 @@
 #  include <initializer_list>
 #  include <type_traits>
 
-#  include "opentelemetry/nostd/detail/decay.h"
-#  include "opentelemetry/nostd/detail/invoke.h"
+#  include "opentelemetry/nostd/detail/decay.h"   // IWYU pragma: export
+#  include "opentelemetry/nostd/detail/invoke.h"  // IWYU pragma: export
 #  include "opentelemetry/version.h"
 
 OPENTELEMETRY_BEGIN_NAMESPACE

api/include/opentelemetry/plugin/detail/dynamic_load_unix.h

@@ -3,11 +3,10 @@
 
 #pragma once
 
+#include <dlfcn.h>
 #include <algorithm>
 #include <memory>
 
-#include <dlfcn.h>
-
 #include "opentelemetry/plugin/detail/dynamic_library_handle.h"
 #include "opentelemetry/plugin/detail/loader_info.h"
 #include "opentelemetry/plugin/detail/utility.h"

api/include/opentelemetry/plugin/dynamic_load.h

@@ -7,9 +7,9 @@
 #include <string>
 
 #ifdef _WIN32
-#  include "opentelemetry/plugin/detail/dynamic_load_windows.h"
+#  include "opentelemetry/plugin/detail/dynamic_load_windows.h"  // IWYU pragma: export
 #else
-#  include "opentelemetry/plugin/detail/dynamic_load_unix.h"
+#  include "opentelemetry/plugin/detail/dynamic_load_unix.h"  // IWYU pragma: export
 #endif
 #include "opentelemetry/version.h"
 

api/include/opentelemetry/plugin/factory.h

@@ -6,7 +6,7 @@
 #include <memory>
 #include <string>
 
-#include "opentelemetry/plugin/detail/utility.h"
+#include "opentelemetry/plugin/detail/utility.h"  // IWYU pragma: export
 #include "opentelemetry/plugin/tracer.h"
 #include "opentelemetry/version.h"
 

api/include/opentelemetry/plugin/tracer.h

@@ -6,7 +6,7 @@
 #include <memory>
 
 #include "opentelemetry/common/key_value_iterable.h"
-#include "opentelemetry/plugin/detail/tracer_handle.h"
+#include "opentelemetry/plugin/detail/tracer_handle.h"  // IWYU pragma: export
 #include "opentelemetry/trace/span_context_kv_iterable.h"
 #include "opentelemetry/trace/tracer.h"
 #include "opentelemetry/version.h"

examples/batch/main.cc

@@ -1,17 +1,29 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
+#include <stdint.h>
+#include <stdio.h>
+#include <chrono>
+#include <iostream>
+#include <memory>
+#include <string>
+#include <thread>
+#include <utility>
+
 #include "opentelemetry/exporters/ostream/span_exporter_factory.h"
+#include "opentelemetry/nostd/detail/decay.h"
+#include "opentelemetry/nostd/shared_ptr.h"
 #include "opentelemetry/sdk/resource/resource.h"
 #include "opentelemetry/sdk/trace/batch_span_processor_factory.h"
 #include "opentelemetry/sdk/trace/batch_span_processor_options.h"
-#include "opentelemetry/sdk/trace/exporter.h"
 #include "opentelemetry/sdk/trace/processor.h"
+#include "opentelemetry/sdk/trace/recordable.h"
+#include "opentelemetry/sdk/trace/tracer_provider.h"
 #include "opentelemetry/sdk/trace/tracer_provider_factory.h"
 #include "opentelemetry/trace/provider.h"
-
-#include <chrono>
-#include <thread>
+#include "opentelemetry/trace/span_id.h"
+#include "opentelemetry/trace/tracer.h"
+#include "opentelemetry/trace/tracer_provider.h"
 
 constexpr int kNumSpans  = 10;
 namespace trace_api      = opentelemetry::trace;

examples/common/foo_library/foo_library.cc

@@ -1,8 +1,14 @@
 // Copyright The OpenTelemetry Authors
 // SPDX-License-Identifier: Apache-2.0
 
+#include "opentelemetry/context/context_value.h"
+#include "opentelemetry/nostd/shared_ptr.h"
+#include "opentelemetry/nostd/unique_ptr.h"
 #include "opentelemetry/sdk/version/version.h"
 #include "opentelemetry/trace/provider.h"
+#include "opentelemetry/trace/scope.h"
+#include "opentelemetry/trace/tracer.h"
+#include "opentelemetry/trace/tracer_provider.h"
 
 namespace trace = opentelemetry::trace;
 namespace nostd = opentelemetry::nostd;