fix: clarify the value of SkillMetadata.path (#12729)

Rename `SkillMetadata.path` to `SkillMetadata.path_to_skills_md` for
clarity.

Would ideally change the type to `AbsolutePathBuf`, but that can be done
later.

Author: bolinfest

codex-rs/app-server/src/codex_message_processor.rs

@@ -6526,7 +6526,7 @@ fn skills_to_info(
     skills
         .iter()
         .map(|skill| {
-            let enabled = !disabled_paths.contains(&skill.path);
+            let enabled = !disabled_paths.contains(&skill.path_to_skills_md);
             codex_app_server_protocol::SkillMetadata {
                 name: skill.name.clone(),
                 description: skill.description.clone(),
@@ -6557,7 +6557,7 @@ fn skills_to_info(
                             .collect(),
                     }
                 }),
-                path: skill.path.clone(),
+                path: skill.path_to_skills_md.clone(),
                 scope: skill.scope.into(),
                 enabled,
             }

codex-rs/core/src/codex.rs

@@ -4734,9 +4734,9 @@ fn skills_to_info(
                         .collect(),
                 }
             }),
-            path: skill.path.clone(),
+            path: skill.path_to_skills_md.clone(),
             scope: skill.scope,
-            enabled: !disabled_paths.contains(&skill.path),
+            enabled: !disabled_paths.contains(&skill.path_to_skills_md),
         })
         .collect()
 }

codex-rs/core/src/mcp/skill_dependencies.rs

@@ -434,7 +434,7 @@ mod tests {
             dependencies: Some(SkillDependencies { tools }),
             policy: None,
             permissions: None,
-            path: PathBuf::from("skill"),
+            path_to_skills_md: PathBuf::from("skill"),
             scope: SkillScope::User,
         }
     }

codex-rs/core/src/mentions.rs

@@ -55,7 +55,7 @@ pub(crate) fn build_skill_name_counts(
     let mut exact_counts: HashMap<String, usize> = HashMap::new();
     let mut lower_counts: HashMap<String, usize> = HashMap::new();
     for skill in skills {
-        if disabled_paths.contains(&skill.path) {
+        if disabled_paths.contains(&skill.path_to_skills_md) {
             continue;
         }
         *exact_counts.entry(skill.name.clone()).or_insert(0) += 1;

codex-rs/core/src/skills/injection.rs

@@ -37,18 +37,18 @@ pub(crate) async fn build_skill_injections(
     let mut invocations = Vec::new();
 
     for skill in mentioned_skills {
-        match fs::read_to_string(&skill.path).await {
+        match fs::read_to_string(&skill.path_to_skills_md).await {
             Ok(contents) => {
                 emit_skill_injected_metric(otel, skill, "ok");
                 invocations.push(SkillInvocation {
                     skill_name: skill.name.clone(),
                     skill_scope: skill.scope,
-                    skill_path: skill.path.clone(),
+                    skill_path: skill.path_to_skills_md.clone(),
                     invocation_type: InvocationType::Explicit,
                 });
                 result.items.push(ResponseItem::from(SkillInstructions {
                     name: skill.name.clone(),
-                    path: skill.path.to_string_lossy().into_owned(),
+                    path: skill.path_to_skills_md.to_string_lossy().into_owned(),
                     contents,
                 }));
             }
@@ -57,7 +57,7 @@ pub(crate) async fn build_skill_injections(
                 let message = format!(
                     "Failed to load skill {name} at {path}: {err:#}",
                     name = skill.name,
-                    path = skill.path.display()
+                    path = skill.path_to_skills_md.display()
                 );
                 result.warnings.push(message);
             }
@@ -121,9 +121,9 @@ pub(crate) fn collect_explicit_skill_mentions(
             if let Some(skill) = selection_context
                 .skills
                 .iter()
-                .find(|skill| skill.path.as_path() == path.as_path())
+                .find(|skill| skill.path_to_skills_md.as_path() == path.as_path())
             {
-                seen_paths.insert(skill.path.clone());
+                seen_paths.insert(skill.path_to_skills_md.clone());
                 seen_names.insert(skill.name.clone());
                 selected.push(skill.clone());
             }
@@ -304,23 +304,27 @@ fn select_skills_from_mentions(
         .collect();
 
     for skill in selection_context.skills {
-        if selection_context.disabled_paths.contains(&skill.path)
-            || seen_paths.contains(&skill.path)
+        if selection_context
+            .disabled_paths
+            .contains(&skill.path_to_skills_md)
+            || seen_paths.contains(&skill.path_to_skills_md)
         {
             continue;
         }
 
-        let path_str = skill.path.to_string_lossy();
+        let path_str = skill.path_to_skills_md.to_string_lossy();
         if mention_skill_paths.contains(path_str.as_ref()) {
-            seen_paths.insert(skill.path.clone());
+            seen_paths.insert(skill.path_to_skills_md.clone());
             seen_names.insert(skill.name.clone());
             selected.push(skill.clone());
         }
     }
 
     for skill in selection_context.skills {
-        if selection_context.disabled_paths.contains(&skill.path)
-            || seen_paths.contains(&skill.path)
+        if selection_context
+            .disabled_paths
+            .contains(&skill.path_to_skills_md)
+            || seen_paths.contains(&skill.path_to_skills_md)
         {
             continue;
         }
@@ -347,7 +351,7 @@ fn select_skills_from_mentions(
         }
 
         if seen_names.insert(skill.name.clone()) {
-            seen_paths.insert(skill.path.clone());
+            seen_paths.insert(skill.path_to_skills_md.clone());
             selected.push(skill.clone());
         }
     }
@@ -479,7 +483,7 @@ mod tests {
             dependencies: None,
             policy: None,
             permissions: None,
-            path: PathBuf::from(path),
+            path_to_skills_md: PathBuf::from(path),
             scope: codex_protocol::protocol::SkillScope::User,
         }
     }

codex-rs/core/src/skills/invocation_utils.rs

@@ -32,10 +32,10 @@ pub(crate) fn build_implicit_skill_path_indexes(
     let mut by_scripts_dir = HashMap::new();
     let mut by_skill_doc_path = HashMap::new();
     for skill in skills {
-        let skill_doc_path = normalize_path(skill.path.as_path());
+        let skill_doc_path = normalize_path(skill.path_to_skills_md.as_path());
         by_skill_doc_path.insert(skill_doc_path, skill.clone());
 
-        if let Some(skill_dir) = skill.path.parent() {
+        if let Some(skill_dir) = skill.path_to_skills_md.parent() {
             let scripts_dir = normalize_path(&skill_dir.join("scripts"));
             by_scripts_dir.insert(scripts_dir, skill);
         }
@@ -118,7 +118,7 @@ pub(crate) async fn ensure_skill_approval_for_command(
 
     let cache_key = SkillApprovalCacheKey {
         skill_name: skill.name.clone(),
-        skill_path: skill.path.clone(),
+        skill_path: skill.path_to_skills_md.clone(),
         skill_scope: skill.scope,
     };
     let already_approved = {
@@ -162,7 +162,7 @@ pub(crate) async fn maybe_emit_implicit_skill_invocation(
     let invocation = SkillInvocation {
         skill_name: candidate.name,
         skill_scope: candidate.scope,
-        skill_path: candidate.path,
+        skill_path: candidate.path_to_skills_md,
         invocation_type: InvocationType::Implicit,
     };
     let skill_scope = match invocation.skill_scope {
@@ -337,7 +337,7 @@ mod tests {
             dependencies: None,
             policy: None,
             permissions: None,
-            path: skill_doc_path,
+            path_to_skills_md: skill_doc_path,
             scope: codex_protocol::protocol::SkillScope::User,
         }
     }