Skip to content

Commit cc8de55

Browse files
committed
fix: add lookup_value_regex for taxonomy rest api
1 parent 9a63ca6 commit cc8de55

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

openedx_tagging/core/tagging/rest_api/v1/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ class TaxonomyView(ModelViewSet):
166166
167167
"""
168168

169+
lookup_value_regex = r"\d+"
169170
serializer_class = TaxonomySerializer
170171
permission_classes = [TaxonomyObjectPermissions]
171172

tests/openedx_tagging/core/tagging/test_views.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,13 @@ def test_detail_taxonomy_404(self) -> None:
195195
response = self.client.get(url)
196196
assert response.status_code == status.HTTP_404_NOT_FOUND
197197

198+
def test_detail_taxonomy_invalud_pk(self) -> None:
199+
url = TAXONOMY_DETAIL_URL.format(pk="invalid")
200+
201+
self.client.force_authenticate(user=self.staff)
202+
response = self.client.get(url)
203+
assert response.status_code == status.HTTP_404_NOT_FOUND
204+
198205
@ddt.data(
199206
(None, status.HTTP_401_UNAUTHORIZED),
200207
("user", status.HTTP_403_FORBIDDEN),

0 commit comments

Comments
 (0)