Fix performance regression in ApproximatePointRangeQuery with Lucene 10.2.1 change#18358
Merged
msfroh merged 11 commits intoopensearch-project:mainfrom May 30, 2025
Merged
Conversation
prudhvigodithi
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Member
Author
|
Waiting for this benchmark PR to get merged #18353, once merged I will test the performance run against this PR. Local tests shown the regression has been fixed. |
3 tasks
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18358 +/- ##
============================================
+ Coverage 72.60% 72.69% +0.08%
- Complexity 67682 67766 +84
============================================
Files 5497 5497
Lines 311819 311811 -8
Branches 45265 45261 -4
============================================
+ Hits 226409 226657 +248
+ Misses 66941 66736 -205
+ Partials 18469 18418 -51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
As we discussed in #18337, in addition to the implementations, we must also control the order of visiting BKD nodes; otherwise, the result of sorted values will be wrong. It appears that we are undertaking identical work (#18337), and I am attempting to fix it as outlined here. If you are pleasure to fix it this way, you can continue. |
Contributor
|
❌ Gradle check result for 63e08e7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Contributor
Member
Author
|
{"run-benchmark-test": "id_4"} |
Member
Author
|
{"run-benchmark-test": "id_13"} |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/3278/ . Final results will be published once the job is completed. |
Contributor
|
The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/3279/ . Final results will be published once the job is completed. |
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/3278/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/104/
|
Collaborator
Benchmark ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-pull-request/3280/
|
Collaborator
Benchmark Baseline Comparison ResultsBenchmark Results for Job: https://build.ci.opensearch.org/job/benchmark-compare/105/
|
Member
Author
|
Just a follow up to see if we can get this merged. |
msfroh
approved these changes
May 30, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
This was referenced Jun 5, 2025
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Gagan6164
pushed a commit
to Gagan6164/OpenSearch
that referenced
this pull request
Jun 8, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
abhita
pushed a commit
to abhita/OpenSearch
that referenced
this pull request
Jun 9, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
This was referenced Jun 12, 2025
65 tasks
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
11 tasks
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Aug 5, 2025
…e 10.2.1 change (opensearch-project#18358) --------- Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
This was referenced Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix regression
Coming from #17961, after upgrading the Lucene version to 10.2.1 seen regression with approximation framework. The current flow:
Lucene 10.2 introduced SIMD vectorized decoding for doc IDs via
readInts24, which delivers oneIntsRefper leaf.From apache/lucene#14176 for BPV = 24, Lucene now decodes the entire block in one go and calls
visitor.visit(IntsRef)just once per leaf block.Also the equivalent
adder.add(IntsRef)was also handled in https://github.com/apache/lucene/pull/14138/files.Update the BKD walk for
intersectRightwith a true right to left traversalMore details #18358 (comment) and #18358 (comment).
Approximation desc sort bug fix related to visit methods and improve the code coverage
Fixed the bug as mentioned here #18358 (comment).
Related Issues
#18313
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.