From 00e6339ff801f69d489252d9ef19b3e8b8606788 Mon Sep 17 00:00:00 2001 From: Joe Liu Date: Tue, 16 Dec 2025 05:10:03 -0600 Subject: [PATCH] stop generating raw ids and instead pick a version from the set of known Version constants which are guaranteed to be valid/masked. Signed-off-by: Joe Liu --- .../src/test/java/org/opensearch/env/NodeMetadataTests.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/src/test/java/org/opensearch/env/NodeMetadataTests.java b/server/src/test/java/org/opensearch/env/NodeMetadataTests.java index 2b899ab492494..a884cf8887f8b 100644 --- a/server/src/test/java/org/opensearch/env/NodeMetadataTests.java +++ b/server/src/test/java/org/opensearch/env/NodeMetadataTests.java @@ -49,7 +49,10 @@ public class NodeMetadataTests extends OpenSearchTestCase { private Version randomVersion() { // VersionUtils.randomVersion() only returns known versions, which are necessarily no later than Version.CURRENT; however we want // also to consider our behaviour with all versions, so occasionally pick up a truly random version. - return rarely() ? Version.fromId(randomInt()) : VersionUtils.randomVersion(random()); + // + // Version.fromId(...) requires the OpenSearch mask to be present, so we must generate ids in the valid masked range. + // The maximum id used elsewhere in this test class is 234217727 (see tooNewVersion()). + return rarely() ? Version.fromId(between(MASK, 234217727)) : VersionUtils.randomVersion(random()); } public void testEqualsHashcodeSerialization() {