-
Notifications
You must be signed in to change notification settings - Fork 665
CONSOLE-3769: Even more openshift/dynamic-plugin-sdk prep work #15778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
CONSOLE-3769: Even more openshift/dynamic-plugin-sdk prep work #15778
Conversation
|
@logonoff: This pull request references CONSOLE-3769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e8ce39 to
8bd47eb
Compare
|
@logonoff: This pull request references CONSOLE-3769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references CONSOLE-3769 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.15" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6baca3d to
a355850
Compare
This reverts commit 86835a7.
6adde96 to
d2f3a7b
Compare
d2f3a7b to
088cd5f
Compare
LegacyConsolePluginManifestFeatureFlag/ModelandModelDefinition#15671 and removedsetPluginStoreExtensionDeclarationrenamed toExtension, because there are no more "static extensions".ExtensionDeclarationtype is removed and its replacement is theExtensiontype.@console/plugin-sdkbarrel files and type reexports are removedLazyLoadertype in@console/plugin-sdkmigrated toAsyncComponentbecause it's only used in that context