More securely parse the version - fixes #161

barryo · barryo · commit 27775f05783a · 2016-01-07T21:36:13.000Z
diff --git a/library/ViMbAdmin/Version.php b/library/ViMbAdmin/Version.php
@@ -95,7 +95,7 @@ public static function getLatest()
             $handle = fopen( 'http://www.opensolutions.ie/open-source/vimbadmin/latest-v3', 'r' );
             if( $handle !== false )
             {
-                self::$_lastestVersion = trim( stream_get_contents( $handle ) );
+                self::$_lastestVersion = preg_replace( "/[^0-9\.]/", "", trim( stream_get_contents( $handle, 12 ) ) );
                 fclose( $handle );
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public static function getLatest()`
`95`	`95`	`$handle = fopen( 'http://www.opensolutions.ie/open-source/vimbadmin/latest-v3', 'r' );`
`96`	`96`	`if( $handle !== false )`
`97`	`97`	`{`
`98`		`- self::$_lastestVersion = trim( stream_get_contents( $handle ) );`
	`98`	`+ self::$_lastestVersion = preg_replace( "/[^0-9\.]/", "", trim( stream_get_contents( $handle, 12 ) ) );`
`99`	`99`	`fclose( $handle );`
`100`	`100`	`}`
`101`	`101`	`}`