From c41f230b22ca26be0d142f30a15deb9d64ae351e Mon Sep 17 00:00:00 2001 From: Matheus Date: Thu, 4 Jul 2024 02:57:23 -0300 Subject: [PATCH 1/2] fix: early return on dimensions or placement == hide --- modules/game_interface/widgets/statsbar.lua | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/modules/game_interface/widgets/statsbar.lua b/modules/game_interface/widgets/statsbar.lua index 52fe855ac3..97fc37e022 100644 --- a/modules/game_interface/widgets/statsbar.lua +++ b/modules/game_interface/widgets/statsbar.lua @@ -196,7 +196,7 @@ function StatsBar.getCurrentStatsBarWithPosition() -- It's made this way so we can call the current stats bar without having to use a switch statement. -- And if it's necessary to add more stats bars like "largeOnLeft" it will be easier to add them -- Without changing this code. - if currentStats.dimension == 'hide' and currentStats.placement == 'hide' then + if currentStats.dimension == 'hide' or currentStats.placement == 'hide' then return nil end -- -- Get full position as a single string. @@ -222,7 +222,7 @@ end function StatsBar.getCurrentStatsBar() -- This method will return the statsbar based on its placement. -- i.e statsBarTop // statsBarBottom - if currentStats.dimension == 'hide' and currentStats.placement == 'hide' then + if currentStats.dimension == 'hide' or currentStats.placement == 'hide' then return nil end -- -- Get full placement. @@ -475,7 +475,13 @@ local function onStatsMousePress(tab, mousePos, mouseButton) end function StatsBar.reloadCurrentTab() + if currentStats.dimension == "hide" then + return + end + local dimension = currentStats.dimension:gsub("^%l", string.upper) + + if statsBarsDimensions[dimension] then return constructStatsBar(dimension, currentStats.placement) else From d0211a74dc3fc9931edfef12e84cf40817fc7564 Mon Sep 17 00:00:00 2001 From: Matheus Date: Thu, 4 Jul 2024 03:01:03 -0300 Subject: [PATCH 2/2] chore: remove empty line --- modules/game_interface/widgets/statsbar.lua | 1 - 1 file changed, 1 deletion(-) diff --git a/modules/game_interface/widgets/statsbar.lua b/modules/game_interface/widgets/statsbar.lua index 97fc37e022..b66ed64a86 100644 --- a/modules/game_interface/widgets/statsbar.lua +++ b/modules/game_interface/widgets/statsbar.lua @@ -480,7 +480,6 @@ function StatsBar.reloadCurrentTab() end local dimension = currentStats.dimension:gsub("^%l", string.upper) - if statsBarsDimensions[dimension] then return constructStatsBar(dimension, currentStats.placement)