Skip to content

Commit 7f05029

Browse files
authored
fix: resolve warnings (#957)
* fix: resolve warnings * fix: add access guard avoid runtime errors * fix: change placeholder prop type * fix: resolve type check * fix: toolbarbaseicon props default value
1 parent bc0eb01 commit 7f05029

14 files changed

Lines changed: 71 additions & 75 deletions

File tree

packages/common/component/MetaCodeEditor.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,8 @@ export default {
255255
minimap: {
256256
enabled: false
257257
}
258-
}
258+
},
259+
locale
259260
}
260261
}
261262
}

packages/common/component/MetaListItems.vue

Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -30,31 +30,33 @@
3030
</vue-draggable-next>
3131
</template>
3232
<template v-else>
33-
<div v-for="(item, index) in optionsList" :key="index" class="option-item not-draggable">
34-
<meta-list-item
35-
:item="item"
36-
:index="index"
37-
:itemClick="itemClick"
38-
:dataScource="listItemOption"
39-
@changeItem="changeItem"
40-
@deleteItem="deleteItem"
41-
@editItem="editItem"
42-
>
43-
<template #content>
44-
<slot name="content" :data="item">
45-
<span>{{ item[textField] || formatName(item) }}</span>
46-
</slot>
47-
</template>
48-
<template #operate>
49-
<slot name="operate" :data="item"></slot>
50-
</template>
51-
<template #metaForm>
52-
<slot name="form" :data="item"></slot>
53-
</template>
54-
<template #footer>
55-
<slot name="footer" :data="item"></slot>
56-
</template>
57-
</meta-list-item>
33+
<div>
34+
<div v-for="(item, index) in optionsList" :key="index" class="option-item not-draggable">
35+
<meta-list-item
36+
:item="item"
37+
:index="index"
38+
:itemClick="itemClick"
39+
:dataScource="listItemOption"
40+
@changeItem="changeItem"
41+
@deleteItem="deleteItem"
42+
@editItem="editItem"
43+
>
44+
<template #content>
45+
<slot name="content" :data="item">
46+
<span>{{ item[textField] || formatName(item) }}</span>
47+
</slot>
48+
</template>
49+
<template #operate>
50+
<slot name="operate" :data="item"></slot>
51+
</template>
52+
<template #metaForm>
53+
<slot name="form" :data="item"></slot>
54+
</template>
55+
<template #footer>
56+
<slot name="footer" :data="item"></slot>
57+
</template>
58+
</meta-list-item>
59+
</div>
5860
</div>
5961
</template>
6062
</template>

packages/common/component/PluginBlockList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ export default {
205205
emits: ['click', 'iconClick', 'add', 'deleteBlock', 'openVersionPanel', 'editBlock', 'checkAll', 'cancelCheckAll'],
206206
setup(props, { emit }) {
207207
const panelState = inject('panelState', {})
208-
const blockUsers = inject('blockUsers')
208+
const blockUsers = inject('blockUsers', [])
209209
const state = reactive({
210210
activeIndex: -1,
211211
data: computed(() => props.data),

packages/common/component/toolbar-built-in/ToolbarBaseButton.vue

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<tiny-button v-bind="extendAttrs" class="toolbar-button">
2+
<tiny-button class="toolbar-button">
33
<span class="svg-wrap">
44
<svg-icon v-if="icon" :name="icon"></svg-icon>
55
<span v-if="options?.showDots" class="dots"></span>
@@ -9,7 +9,6 @@
99
</tiny-button>
1010
</template>
1111
<script>
12-
import { inject } from 'vue'
1312
import { Button } from '@opentiny/vue'
1413
1514
export default {
@@ -29,12 +28,6 @@ export default {
2928
type: Object,
3029
default: () => ({})
3130
}
32-
},
33-
setup() {
34-
const extendAttrs = inject('extend-attributes') || {}
35-
return {
36-
extendAttrs
37-
}
3831
}
3932
}
4033
</script>

packages/common/component/toolbar-built-in/ToolbarBaseIcon.vue

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
>
99
<template #reference>
1010
<span class="icon">
11-
<span class="icon-hides" v-bind="extendAttrs">
11+
<span class="icon-hides" v-bind="$attrs">
1212
<svg-icon :name="icon"></svg-icon>
1313
<span v-if="options?.showDots" class="dots"></span>
1414
</span>
@@ -17,7 +17,6 @@
1717
</tiny-popover>
1818
</template>
1919
<script>
20-
import { inject } from 'vue'
2120
import { Popover } from '@opentiny/vue'
2221
2322
export default {
@@ -35,13 +34,7 @@ export default {
3534
},
3635
options: {
3736
type: Object,
38-
default: () => {}
39-
}
40-
},
41-
setup() {
42-
const extendAttrs = inject('extend-attributes') || {}
43-
return {
44-
extendAttrs
37+
default: () => ({})
4538
}
4639
}
4740
}

packages/configurator/src/tabs-group-configurator/TabsGroupConfigurator.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ const props = defineProps({
7878
},
7979
// tabItem宽度
8080
labelWidth: {
81-
type: Number,
82-
default: 63
81+
type: [Number, String],
82+
default: '63'
8383
},
8484
// tab的选项,如果选项中包含collapsed,则会折叠为下拉
8585
options: {

packages/layout/src/DesignSettings.vue

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div id="tiny-right-panel">
33
<tiny-tabs v-model="layoutState.settings.render">
44
<tiny-tab-item v-for="(setting, index) in settings" :key="index" :title="setting.title" :name="setting.name">
5-
<component :is="setting.entry" :is-collapsed="isCollapsed"></component>
5+
<component :is="setting.entry"></component>
66
<div v-show="activating" class="active"></div>
77
</tiny-tab-item>
88
</tiny-tabs>
@@ -15,14 +15,15 @@
1515
</template>
1616

1717
<script>
18-
import { computed, ref } from 'vue'
19-
import { Tabs, TabItem } from '@opentiny/vue'
18+
import { computed, provide, ref } from 'vue'
19+
import { Tabs, TabItem, Tooltip } from '@opentiny/vue'
2020
import { useLayout } from '@opentiny/tiny-engine-meta-register'
2121
2222
export default {
2323
components: {
2424
TinyTabs: Tabs,
25-
TinyTabItem: TabItem
25+
TinyTabItem: TabItem,
26+
TinyTooltip: Tooltip
2627
},
2728
props: {
2829
settings: {
@@ -37,6 +38,8 @@ export default {
3738
const isCollapsed = ref(false)
3839
const settingIcon = computed(() => (isCollapsed.value ? 'style-panel-collapsed' : 'style-panel-expand'))
3940
41+
provide('isCollapsed', isCollapsed)
42+
4043
return {
4144
showMask,
4245
isCollapsed,

packages/plugins/i18n/src/Main.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
</tiny-grid-column>
115115
<template #empty>
116116
<div v-if="isLoading" id="empty-loading-box" class="i18n-loading"></div>
117-
<search-empty isShow="!isLoading" />
117+
<search-empty v-else />
118118
</template>
119119
</tiny-grid>
120120
</div>

packages/plugins/materials/src/meta/block/src/BlockGroup.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ export default {
168168
default: () => []
169169
}
170170
},
171+
emits: ['changeGroup'],
171172
setup(props) {
172173
const validateIcon = iconError()
173174
const panelState = inject('panelState', {})

packages/plugins/materials/src/meta/block/src/BlockList.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<template>
22
<plugin-block-list
3-
class="block-list-wrap"
43
ref="blockRef"
54
:data="blockList"
65
:show-add-button="state.showAddButton"

0 commit comments

Comments
 (0)