Skip to content

Conversation

@perdasilva
Copy link
Collaborator

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Per Goncalves da Silva added 3 commits August 20, 2024 09:49
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/bump-all-the-things-2 branch from bd4f223 to dbd541f Compare August 20, 2024 14:19
@iamniting
Copy link

Can we pls prioritize this PR we require this to solve the #3375

Signed-off-by: Todd Short <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2024
@dtfranz dtfranz added this pull request to the merge queue Aug 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
* update libraries

Signed-off-by: Per Goncalves da Silva <[email protected]>

* update vendor

Signed-off-by: Per Goncalves da Silva <[email protected]>

* update generated code

Signed-off-by: Per Goncalves da Silva <[email protected]>

* fixes

Signed-off-by: Per Goncalves da Silva <[email protected]>

* Update to generics

Signed-off-by: Todd Short <[email protected]>

* Separate out e2e flakes

Signed-off-by: Todd Short <[email protected]>

---------

Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Todd Short <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Todd Short <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@tmshort tmshort added this pull request to the merge queue Aug 27, 2024
Merged via the queue into operator-framework:master with commit c730fbc Aug 27, 2024
@iamniting
Copy link

Thanks to everyone who worked on this. I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants