Skip to content

Consider a String object an object instead of string in node-api #25353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjvalencik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Consider a String object an object instead of string in node-api #25353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bun.js/bindings/napi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2390,6 +2390,8 @@ extern "C" napi_status napi_typeof(napi_env env, napi_value val,
return napi_clear_last_error(env);

case JSC::ObjectType:
case JSC::StringObjectType:
case JSC::DerivedStringObjectType:
if (JSC::jsDynamicCast<Bun::NapiExternal*>(value)) {
*result = napi_external;
return napi_clear_last_error(env);
Expand All @@ -2401,8 +2403,6 @@ extern "C" napi_status napi_typeof(napi_env env, napi_value val,
case JSC::HeapBigIntType:
*result = napi_bigint;
return napi_clear_last_error(env);
case JSC::DerivedStringObjectType:
case JSC::StringObjectType:
case JSC::StringType:
*result = napi_string;
return napi_clear_last_error(env);
Expand Down