Revert "fix: clean up ESM registry when require() of ESM module fails…#27325
Merged
Jarred-Sumner merged 1 commit intomainfrom Feb 21, 2026
Merged
Revert "fix: clean up ESM registry when require() of ESM module fails…#27325Jarred-Sumner merged 1 commit intomainfrom
Jarred-Sumner merged 1 commit intomainfrom
Conversation
Collaborator
|
Updated 2:23 AM PT - Feb 21st, 2026
❌ @dylan-conway, your commit ba4fc52 has 5 failures in
🧪 To try this PR locally: bunx bun-pr 27325That installs a local version of the PR into your bun-27325 --bun |
Contributor
|
No actionable comments were generated in the recent review. 🎉 WalkthroughModified error handling in CommonJS module loading to preserve Loader.registry entries on exception, and removed a regression test for module evaluation behavior involving CJS require() and ESM import() interaction. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#27288)"
This reverts commit 21c3439.