Default Length for StringDataFrameColumn (dotnet#2921) (dotnet#2923)

rhysparry · web-flow · commit 8d08434afa3d · 2020-05-25T10:35:15.000-07:00
diff --git a/src/Microsoft.Data.Analysis/StringDataFrameColumn.cs b/src/Microsoft.Data.Analysis/StringDataFrameColumn.cs
@@ -19,7 +19,7 @@ public partial class StringDataFrameColumn : DataFrameColumn, IEnumerable<string
     {
         private List<List<string>> _stringBuffers = new List<List<string>>(); // To store more than intMax number of strings
 
-        public StringDataFrameColumn(string name, long length) : base(name, length, typeof(string))
+        public StringDataFrameColumn(string name, long length = 0) : base(name, length, typeof(string))
         {
             int numberOfBuffersRequired = Math.Max((int)(length / int.MaxValue), 1);
             for (int i = 0; i < numberOfBuffersRequired; i++)

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public partial class StringDataFrameColumn : DataFrameColumn, IEnumerable<string`
`19`	`19`	`{`
`20`	`20`	`private List<List<string>> _stringBuffers = new List<List<string>>(); // To store more than intMax number of strings`
`21`	`21`
`22`		`- public StringDataFrameColumn(string name, long length) : base(name, length, typeof(string))`
	`22`	`+ public StringDataFrameColumn(string name, long length = 0) : base(name, length, typeof(string))`
`23`	`23`	`{`
`24`	`24`	`int numberOfBuffersRequired = Math.Max((int)(length / int.MaxValue), 1);`
`25`	`25`	`for (int i = 0; i < numberOfBuffersRequired; i++)`