feat: make to_html deterministic#3487
Merged
nicolaskruchten merged 5 commits intoplotly:masterfrom Dec 20, 2021
Merged
Conversation
Contributor
|
Thanks for this PR! Unfortunately, I won't be able to accept it as-is, as it might break things for folks who are using this function to generate HTML fragments for multiple figures, and then injecting them into the same downstream HTML file. I would recommend adding a new argument to the end of the argument list like |
Contributor
Author
|
Hi Nicolas, thanks for getting back so fast! That makes a lot of sense, didn't think of usecases where multiple HTML outputs are in the same file. Implemented in 3b461a7. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3449
This PR makes
to_htmldeterministic. It does so by using a static ID for the HTML div that the plots are rendered into, as opposed to a random UUID that changes on every run.This is useful when HTML reports are tracked using tools like DVC, where a difference in checksum is used as an indicator for content change.
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).