Fix potential crash due to handling scores in leaderboard post-disposal (#36860)

peppy · web-flow · commit c4402e9ce511 · 2026-03-07T04:40:25.000+09:00
Closes #36858. Classic.
diff --git a/osu.Game/Screens/Select/BeatmapLeaderboardWedge.cs b/osu.Game/Screens/Select/BeatmapLeaderboardWedge.cs
@@ -256,7 +256,9 @@ public void RefetchScores()
                 {
                     // only bind this after the first fetch to avoid reading stale scores.
                     fetchedScores.BindTo(leaderboardManager.Scores);
-                    fetchedScores.BindValueChanged(_ => updateScores(), true);
+
+                    // Schedule is important here to avoid handling changes after this drawable is disposed.
+                    fetchedScores.BindValueChanged(_ => Schedule(updateScores), true);
                     initialFetchComplete = true;
                 }
             }, initialFetchComplete && fetchScope != BeatmapLeaderboardScope.Local ? 300 : 0);

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,9 @@ public void RefetchScores()`
`256`	`256`	`{`
`257`	`257`	`// only bind this after the first fetch to avoid reading stale scores.`
`258`	`258`	`fetchedScores.BindTo(leaderboardManager.Scores);`
`259`		`- fetchedScores.BindValueChanged(_ => updateScores(), true);`
	`259`	`+`
	`260`	`+ // Schedule is important here to avoid handling changes after this drawable is disposed.`
	`261`	`+ fetchedScores.BindValueChanged(_ => Schedule(updateScores), true);`
`260`	`262`	`initialFetchComplete = true;`
`261`	`263`	`}`
`262`	`264`	`}, initialFetchComplete && fetchScope != BeatmapLeaderboardScope.Local ? 300 : 0);`