Skip to content

Conversation

@dnfd1
Copy link
Contributor

@dnfd1 dnfd1 commented Oct 9, 2025

Resolves #35186

This change sets the OD bindable in ModDifficultyAdjust to virtual and the mania specific difficulty adjust mod is changed to override the bindable and set extended OD limits to their EZ minimum and HR maximum.

image image

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much in way of source to look at here, but I don't foresee merging this on my own without a second check with @ppy/team-client that nobody has major ideological oppositions to entertaining this type of change.

Comment on lines 15 to 16
ExtendedMaxValue = 13.61f,
ExtendedMinValue = -14.93f,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An inline comment describing where these specific values come from is probably warranted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a comment explaining it even though I rounded the values, since I figure it's probably useful to know why the limits are even being overriden in the first place

MinValue = 0,
MaxValue = 10,
ExtendedMaxValue = 13.61f,
ExtendedMinValue = -14.93f,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative OD looks very wrong.

Copy link
Collaborator

@bdach bdach Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but you actually can get into "negative OD" territory when applying Easy mod because of how special mania Easy / Hard Rock are. See #34227.

(And again, we're kinda already there elsewhere - osu! Difficulty Adjust permits negative AR already...)

Comment on lines 15 to 16
ExtendedMaxValue = 13.61f,
ExtendedMinValue = -14.93f,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use round numbers. 13.61 is meaningless.

Copy link
Collaborator

@bdach bdach Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not that meaningless. -14.93 is what the "effective" OD is when EZ is applied to a beatmap with baseline OD 0, and 13.61 is what the "effective" OD is when HR is applied to a beatmap with baseline OD 10. (Which is why I asked for inline comments explaining what these magic numbers are.)

Whether this should be exposed to people as an option is the debate I'm interested in, but do note we're kind of already halfway there given #34227 is a thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the above comment from the user's perspective.

In other words, round it to -15/+15?

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no real objections left from me, not sure about everyone else

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fine from me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Difficulty Adjust mod on osu!mania can't increase the OD rating of a map as much as Hard Rock does

4 participants