Several improvements to quick play chat input #35432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
force-pushed
the
improve-qp-chat
branch
from
4ca8e60 to
613c208
Compare
16 tasks
peppy
approved these changes
Oct 24, 2025
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
Can't find any immediate issues.
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35337
Proxying the chat doesn't work quite correctly because, input wise, it is still below the footer which blocks input (because it's an
OverlayContainerand that's how they work). Instead, we have to move the chat entirely into the footer.Because it's now a static component, I've added appear/disappear animations for it (same implementation as
ScreenFooterButton):2025-10-24.21-30-28.mp4
Furthermore there's a separate issue where the chat is physically too small to contain the entirety of the context menu within its boundary (which was
DrawableChannel), so you couldn't reach the report/block buttons. I've fixed this by moving the context menu container to a higher level:2025-10-24.21-27-11.mp4
Although this change affects
ChatOverlay(context menu container moved up one level), I don't think there is any functional difference.