Show quit quick play users rather than removing them

[smoogipoo]

• Depends on Add grayscale shader osu-framework#6662
• Depends on framework package w/ above

Fixes #35355

The code may look a bit hacky, but it is necessary due to the avatar proxying thus requiring two buffered containers.

2025-10-27.18-55-25.mp4

2025-10-27.19-09-08.mp4

[bdach]

You're probably not going to like me pointing this out, but visually it's a bit of a step down with buffered containers...

Screen.Recording.2025-10-27.at.12.11.37.mov

• The major one is that the local player(?)'s yellow border is very looking very... square - I think this one is blocker tier
• The scale transform effect on hover pretty clearly shows that this is a buffered container and not in a good way (downsampled avatars getting upsampled / blurry again) - maybe passable

[smoogipoo]

I like your fix better than what I was going to do to fix it 👍

[smoogipoo]

The scale transform effect on hover pretty clearly shows that this is a buffered container and not in a good way

We can possibly render the framebuffer at a higher scale. How does this look to you (visually)?

diff --git a/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs b/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
index 6884312f3d..5c672828e5 100644
--- a/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
+++ b/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
@@ -137,6 +137,7 @@ private void load()
             Child = backgroundQuitTarget = new BufferedContainer
             {
                 RelativeSizeAxes = Axes.Both,
+                FrameBufferScale = new Vector2(1.5f),
                 Children = new[]
                 {
                     solidBackgroundLayer = new Box
@@ -189,6 +190,7 @@ private void load()
                                             Child = avatarQuitTarget = new BufferedContainer
                                             {
                                                 RelativeSizeAxes = Axes.Both,
+                                                FrameBufferScale = new Vector2(1.5f),
                                                 Child = new MatchmakingAvatar(User, isOwnUser: User.Id == api.LocalUser.Value.Id)
                                                 {
                                                     Anchor = Anchor.Centre,

[peppy]

I thought buffered containers will re-render on draw scale changes by default 🤔

[smoogipoo]

It does... Could be pixel alignment maybe? Not sure.

[peppy]

The blurriness of all the text is from pixel alignment:

Before	After

Enabling pixel alignment makes the positional changes look really bad, so it's not a solution.

The buffered container may not be redrawn at correct resolution DrawScale is not changing, since the scale is adjusted at a parent. Not 100% on this one.

[peppy]

@smoogipoo is there a reason why the avatar needs its own greyscale effect applied even though it's within the out buffered container?

[smoogipoo]

@peppy The avatar needs its own buffered container because it's proxied out of the buffer and into a container that doesn't mask. And proxies follow the final draw tree.

[peppy]

🙈

[bdach]

A few other things:

• Maybe not relevant, but the "quit" state doesn't look right when the panel is in "avatar only" mode:

  Screen.Recording.2025-10-28.at.08.43.34.mov

  Said mode seemingly isn't used anywhere, though, so as I said, possibly irrelevant.

• Avatar fades out instantly when PlayerPanelOverlay is transitioned to hidden state:

  Screen.Recording.2025-10-28.at.08.44.01.mov

  Not exactly sure why this is failing, but can be hacked around with

  diff --git a/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs b/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
  index 0d5f36585c..dd012555f6 100644
  --- a/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
  +++ b/osu.Game/Screens/OnlinePlay/Matchmaking/Match/PlayerPanel.cs
  @@ -368,6 +368,13 @@ private void updateLayout(bool instant)
               }
           }
   
  +        protected override void Update()
  +        {
  +            base.Update();
  +
  +            avatarQuitTarget.Alpha = Alpha;
  +        }
  +
           protected override bool OnHover(HoverEvent e)
           {
               Content.ScaleTo(1.03f, 2000, Easing.OutPow10);
  

[peppy]

Not exactly sure why this is failing, but can be hacked around with

I feel we may be taking these hacks to a level of too-hacky...

[peppy]

@bdach have fixed the remaining two issues you found, will leave to you for final testing.

[bdach]