Fix bad performance when moving mouse to left side of song select forcibly expands group with current selection #35543
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cibly expands group with current selection Calling `HandleItemActivated()` rather than its intended 'parent method' of `Activate()` meant that selection state was not correctly invalidated: https://github.com/ppy/osu/blob/819da1bc38dbc9676f8f1ee3924bfd8d9cb50347/osu.Game/Graphics/Carousel/Carousel.cs#L157 which in turn meant that carousel item Y positions would not be recalculated correctly after the group was expanded, which meant that the items would become - visible, - stuck to the bottom of the expanded group, - one on top of another. Which is not something that's going to perform well. Certified OOP moment.
bdach
added
type/performance
peppy
approved these changes
Oct 31, 2025
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35514.
Calling
HandleItemActivated()rather than its intended 'parent method' ofActivate()meant that selection state was not correctly invalidated:osu/osu.Game/Graphics/Carousel/Carousel.cs
Line 157 in 819da1b
which in turn meant that carousel item Y positions would not be recalculated correctly after the group was expanded, which meant that the items would become
Which is not something that's going to perform well.
Certified OOP moment.