Split quickplay beatmap & "random" panel into separate classes (V2) #35701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minetoblend
force-pushed
the
feature/quickplay-beatmap-bulk-fetch
branch
from
a1668d1 to
7d7ff4b
Compare
minetoblend
commented
Nov 14, 2025
3 tasks
smoogipoo
requested changes
Nov 17, 2025
osu.Game/Screens/OnlinePlay/Matchmaking/Match/BeatmapSelect/MatchmakingSelectPanelBeatmap.cs
Outdated
Show resolved
Hide resolved
osu.Game/Screens/OnlinePlay/Matchmaking/Match/BeatmapSelect/SubScreenBeatmapSelect.cs
Outdated
Show resolved
Hide resolved
smoogipoo
reviewed
Nov 17, 2025
osu.Game/Screens/OnlinePlay/Matchmaking/Match/BeatmapSelect/BeatmapSelectGrid.cs
Show resolved
Hide resolved
smoogipoo
approved these changes
Nov 17, 2025
Contributor
smoogipoo
left a comment
smoogipoo
left a comment
There was a problem hiding this comment.
Seems probably okay. I'm starting to feel a little concerned about loading every beatmap before displaying anything, but perhaps we'll cross that point when we get to it by querying every beatmap in the background on room join or something.
I've done some simple merge conflict resolution expecting the followup PR to remove it or move it elsewhere appropriate.
This was referenced Nov 21, 2025
This was referenced Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #35695
Prerequisite for #35704
Attempt number two... I tried to keep the changeset as small as possible this time, managed to cut it down to a third the original size.
The PR attempts to split the
BeatmapSelectPanelclass into two subclasses based on panel type, to make it easier to implement custom animations/designs for each panel type in follow-up work (see #35704).The PR also moves the responsibility for fetching the
APIBeatmaps into the matchmaking subscreen, which loads them in bulk and then hands everything to theBeatmapSelectGridall at once. Came up on discord, and it made passing the data to the panels a lot easier.