-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Use new sliders-with-text-input in editor toolboxes #35742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Addresses ppy#35732. And yes, I renamed "perfect curve threshold" to "bias" so that the text can fit. Sue me.
|
I know it's also the case on And there's probably a very good (bad) reason it needs to be this way because bindables and existing |
I don't think there is in this case actually. Aside from distance snap which is already constrained to 0.01 increments for stable reasons everything else is pretty fair game - the other settings aren't persisted, and in the case of something like the slider drawing controls they feature completely make-believe non-unit numbers. I can probably set a precision for these and see if we get complaints. |
|
sounds good. it just looks a bit silly having so much precision for no real reason. |
…extboxes Noticed in ppy/osu#35742.
In a perfect world you could specify different precisions for the slider and the text box but let's start here and see if we get complaints first.
f3409c9 to
f0f33b6
Compare
|
The precision changes feel much better. But one other thing I've noticed is that we're missing the reset-to-default double click behaviour: osu.2025-11-21.at.05.58.12.mp4Probably should be reimplemented as a follow-up effort though? |
|
Yeah I dunno. Maybe. I find the double-click-to-reset-to-default behaviour arcane but I can try as a follow-up. |
|
It's a pretty powerful action once you get used to it. If we're not going to have it, at very least we need the "revert to default" button to exist somewhere. Probably both, in the optimal world. |
|
Revert to default is something I want to eventually get around to so that we can use these controls in settings. Problem with settings is that |
Screen.Recording.2025-11-19.at.13.37.38.mov
TextBoxnot allowing minus sign to be input in numerical type textboxes osu-framework#6672Addresses #35732.
And yes, I renamed "perfect curve threshold" to "bias" so that the text can fit. Sue me.