Skip to content

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Nov 19, 2025

Screen.Recording.2025-11-19.at.13.37.38.mov

Addresses #35732.

And yes, I renamed "perfect curve threshold" to "bias" so that the text can fit. Sue me.

Addresses ppy#35732.

And yes, I renamed "perfect curve threshold" to "bias" so that the text
can fit. Sue me.
@bdach bdach requested a review from peppy November 19, 2025 12:40
@bdach bdach self-assigned this Nov 19, 2025
@bdach bdach added area:editor type/cosmetic Only affects the game visually. Doesn't affect things working or not working. labels Nov 19, 2025
@bdach bdach moved this from Next up to Pending Review in @peppy's untitled project Nov 19, 2025
@peppy
Copy link
Member

peppy commented Nov 19, 2025

I know it's also the case on master, but the precision when dragging those sliders feels... way too precise.

And there's probably a very good (bad) reason it needs to be this way because bindables and existing .osu files so I'm not sure why I'm even bringing this up.

@bdach
Copy link
Collaborator Author

bdach commented Nov 20, 2025

And there's probably a very good (bad) reason it needs to be this way because bindables and existing .osu files so I'm not sure why I'm even bringing this up.

I don't think there is in this case actually. Aside from distance snap which is already constrained to 0.01 increments for stable reasons everything else is pretty fair game - the other settings aren't persisted, and in the case of something like the slider drawing controls they feature completely make-believe non-unit numbers. I can probably set a precision for these and see if we get complaints.

@peppy
Copy link
Member

peppy commented Nov 20, 2025

sounds good. it just looks a bit silly having so much precision for no real reason.

In a perfect world you could specify different precisions for the slider
and the text box but let's start here and see if we get complaints
first.
@bdach bdach force-pushed the eternal-war-against-sliders branch from f3409c9 to f0f33b6 Compare November 20, 2025 11:36
@peppy
Copy link
Member

peppy commented Nov 21, 2025

The precision changes feel much better. But one other thing I've noticed is that we're missing the reset-to-default double click behaviour:

osu.2025-11-21.at.05.58.12.mp4

Probably should be reimplemented as a follow-up effort though?

@bdach
Copy link
Collaborator Author

bdach commented Nov 21, 2025

Yeah I dunno. Maybe. I find the double-click-to-reset-to-default behaviour arcane but I can try as a follow-up.

@peppy
Copy link
Member

peppy commented Nov 21, 2025

It's a pretty powerful action once you get used to it. If we're not going to have it, at very least we need the "revert to default" button to exist somewhere. Probably both, in the optimal world.

@peppy peppy merged commit 19f5e5b into ppy:master Nov 21, 2025
7 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in @peppy's untitled project Nov 21, 2025
@bdach
Copy link
Collaborator Author

bdach commented Nov 21, 2025

Revert to default is something I want to eventually get around to so that we can use these controls in settings. Problem with settings is that SettingsItem is ridiculous sprawl with 40 weird features tacked onto it and it's practically a rewrite job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:editor size/L type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants