Show self in online users list #35803
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see a reason to hide self. I kinda expect to be able to see that I'm online.
peppy
added
the
quick fix
github-project-automation
bot
moved this to Ready for work
in @peppy's untitled project
Collaborator
|
When I initially implemented this, this display would show self. This changed in a51938f. I vaguely recall having conversations about reasoning for why but I can't locate them anymore, so cc @smoogipoo in hopes that we can maybe rely on memory to resolve that. |
Member
Author
|
I did ask him IRL before making this change, so I'm not sure he's got anything to add here 😅 |
Contributor
|
I don't remember why that change was made, we just likely thought it different at that time. |
bdach
approved these changes
Nov 25, 2025
github-project-automation
bot
moved this from Pending Review
to Done
in @peppy's untitled project
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see a reason to hide self. I kinda expect to be able to see that I'm online.