fix: Improve descriptor extension interoperability#2232
Merged
Conversation
alexander-fenster
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves
ext/descriptorinteroperability by fixing descriptor input handling for buffers/readers, preservingproto3_optionalcorrectly, and reconstructing descriptor map fields asMapFields.Also moves the descriptor extension one level up for better modern ESM/TypeScript consumption with
.jsimport specifiers, keeps a backwards-compatible shim folder, and improves its TypeScript declarations. The declarations now properly augment the parent protobuf.js types when the descriptor extension is used.