fix: address comments

Signed-off-by: yihong0618 <[email protected]>

Author: yihong0618

Lib/test/test_exceptions.py

@@ -1843,6 +1843,36 @@ def test_memory_error_in_subinterp(self):
         rc, _, err = script_helper.assert_python_ok("-c", code)
         self.assertIn(b'MemoryError', err)
 
+    @cpython_only
+    # Python built with Py_TRACE_REFS fail with a fatal error in
+    # _PyRefchain_Trace() on memory allocation error.
+    @unittest.skipIf(support.Py_TRACE_REFS, 'cannot test Py_TRACE_REFS build')
+    def test_exec_set_nomemory_hang(self):
+        import_module("_testcapi")
+        # gh-134163: Test case that triggers no memory hang condition
+        # The frame_lasti need to upper 257,
+        # because when calling PyLong_FromLong, malloc is not invoked,
+        # so no MemError is triggered
+        # we need to warm up the memory to reproduce the issue
+        warmup_code = "a = list(range(0, 1))\n" * 20
+        user_input = warmup_code + dedent("""
+            try:
+                import _testcapi
+                _testcapi.set_nomemory(0)
+                b = list(range(1000, 2000))
+            except Exception as e:
+                import traceback
+                traceback.print_exc()
+            """)
+        with SuppressCrashReport():
+            with script_helper.spawn_python('-c', user_input) as p:
+                p.wait()
+                output = p.stdout.read()
+
+        self.assertIn(p.returncode, (0, 1))
+        self.assertGreater(len(output), 0)  # At minimum, should not hang
+        self.assertIn(b"MemoryError", output)
+
 
 class NameErrorTests(unittest.TestCase):
     def test_name_error_has_name(self):

Lib/test/test_repl.py

@@ -14,7 +14,7 @@
     SuppressCrashReport,
     SHORT_TIMEOUT,
 )
-from test.support.script_helper import kill_python, spawn_python
+from test.support.script_helper import kill_python
 from test.support.import_helper import import_module
 
 try:
@@ -98,35 +98,6 @@ def test_no_memory(self):
         # Exit code 120: Py_FinalizeEx() failed to flush stdout and stderr.
         self.assertIn(p.returncode, (1, 120))
 
-    @cpython_only
-    # Python built with Py_TRACE_REFS fail with a fatal error in
-    # _PyRefchain_Trace() on memory allocation error.
-    @unittest.skipIf(support.Py_TRACE_REFS, 'cannot test Py_TRACE_REFS build')
-    def test_exec_set_nomemory_hang(self):
-        import_module("_testcapi")
-        # gh-134163: Test case that triggers no memory hang condition
-        # The frame_lasti need to upper 257,
-        # because when calling PyLong_FromLong, malloc is not invoked,
-        # so no MemError is triggered
-        # we need to warm up the memory to reproduce the issue
-        warmup_code = "a = list(range(0, 1))\n" * 20
-        user_input = warmup_code + dedent("""
-            try:
-                import _testcapi
-                _testcapi.set_nomemory(0)
-                b = list(range(1000, 2000))
-            except Exception as e:
-                import traceback
-                traceback.print_exc()
-            """)
-        with SuppressCrashReport():
-            p = spawn_python('-c', user_input)
-        output = kill_python(p)
-
-        self.assertIn(p.returncode, (0, 1, 120))
-        self.assertGreater(len(output), 0)  # At minimum, should not hang
-        self.assertIn(b"MemoryError", output)
-
     @cpython_only
     def test_multiline_string_parsing(self):
         # bpo-39209: Multiline string tokens need to be handled in the tokenizer