bpo-40366: Remove support for passing CO_NESTED as a flag to compile

Author: isidentical

Doc/whatsnew/3.9.rst

@@ -791,6 +791,9 @@ Removed
   deprecated since 2006, and only returning ``False`` when it's called.
   (Contributed by Batuhan Taskaya in :issue:`40208`)
 
+* Support for passing ``CO_NESTED`` flag to :func:`compile` has been removed.
+  It was obsolete and the default behavior since Python 2.2, 19 years.
+  (Contributed by Batuhan Taskaya in :issue:`40366`)
 
 Porting to Python 3.9
 =====================

Include/compile.h

@@ -17,7 +17,6 @@ PyAPI_FUNC(PyCodeObject *) PyNode_Compile(struct _node *, const char *);
                    CO_FUTURE_WITH_STATEMENT | CO_FUTURE_PRINT_FUNCTION | \
                    CO_FUTURE_UNICODE_LITERALS | CO_FUTURE_BARRY_AS_BDFL | \
                    CO_FUTURE_GENERATOR_STOP | CO_FUTURE_ANNOTATIONS)
-#define PyCF_MASK_OBSOLETE (CO_NESTED)
 
 /* bpo-39562: CO_FUTURE_ and PyCF_ constants must be kept unique.
    PyCF_ constants can use bits from 0x0100 to 0x10000.

Lib/test/test_builtin.py

@@ -20,7 +20,7 @@
 import warnings
 from contextlib import ExitStack
 from functools import partial
-from inspect import CO_COROUTINE
+from inspect import CO_COROUTINE, CO_NESTED
 from itertools import product
 from textwrap import dedent
 from types import AsyncGeneratorType, FunctionType
@@ -339,6 +339,7 @@ def test_compile(self):
         compile('print("\xe5")\n', '', 'exec')
         self.assertRaises(ValueError, compile, chr(0), 'f', 'exec')
         self.assertRaises(ValueError, compile, str('a = 1'), 'f', 'bad')
+        self.assertRaises(ValueError, compile, 'obsolote_flag', 'f', 'exec', CO_NESTED)
 
         # test the optimize argument
 

Misc/NEWS.d/next/Core and Builtins/2020-04-23-02-28-33.bpo-40366.pDs7Zh.rst

@@ -0,0 +1 @@
+Removed support for ``CO_NESTED`` flag in :func:`compile`.

Python/bltinmodule.c

@@ -738,14 +738,11 @@ builtin_compile_impl(PyObject *module, PyObject *source, PyObject *filename,
         cf.cf_feature_version = feature_version;
     }
 
-    if (flags &
-        ~(PyCF_MASK | PyCF_MASK_OBSOLETE | PyCF_COMPILE_MASK))
-    {
+    if (flags & ~(PyCF_MASK | PyCF_COMPILE_MASK)) {
         PyErr_SetString(PyExc_ValueError,
                         "compile(): unrecognised flags");
         goto error;
     }
-    /* XXX Warn if (supplied_flags & PyCF_MASK_OBSOLETE) != 0? */
 
     if (optimize < -1 || optimize > 2) {
         PyErr_SetString(PyExc_ValueError,

Python/ceval.c

@@ -4913,12 +4913,6 @@ PyEval_MergeCompilerFlags(PyCompilerFlags *cf)
             result = 1;
             cf->cf_flags |= compilerflags;
         }
-#if 0 /* future keyword */
-        if (codeflags & CO_GENERATOR_ALLOWED) {
-            result = 1;
-            cf->cf_flags |= CO_GENERATOR_ALLOWED;
-        }
-#endif
     }
     return result;
 }