Skip to content

Commit 80c9675

Browse files
authored
Fixes for ITComputeTest (googleapis#3667)
- add scopes
1 parent 509b079 commit 80c9675

File tree

1 file changed

+15
-5
lines changed
  • google-cloud-clients/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/it

1 file changed

+15
-5
lines changed

google-cloud-clients/google-cloud-compute/src/test/java/com/google/cloud/compute/v1/it/ITComputeTest.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.cloud.compute.v1.DiskTypesScopedList;
3030
import com.google.cloud.compute.v1.ListDiskTypesHttpRequest;
3131
import com.google.cloud.compute.v1.ProjectName;
32+
import com.google.cloud.compute.v1.ProjectRegionDiskTypeName;
3233
import com.google.cloud.compute.v1.ProjectZoneDiskTypeName;
3334
import com.google.cloud.compute.v1.ProjectZoneName;
3435
import com.google.common.collect.Lists;
@@ -57,7 +58,8 @@ public class ITComputeTest {
5758

5859
@BeforeClass
5960
public static void beforeClass() throws IOException{
60-
Credentials credentials = GoogleCredentials.getApplicationDefault();
61+
Credentials credentials = GoogleCredentials.getApplicationDefault().createScoped(
62+
DiskTypeSettings.getDefaultServiceScopes());
6163

6264
diskTypeSettings =
6365
DiskTypeSettings.newBuilder().setCredentialsProvider(FixedCredentialsProvider.create(credentials)).build();
@@ -131,10 +133,18 @@ public void testAggregatedListDiskTypes() {
131133
}
132134
assertThat(diskTypeIterator.size()).isGreaterThan(0);
133135
for (DiskType diskType : diskTypeIterator) {
134-
assertThat(diskType.getZone()).isNotNull();
135-
ProjectZoneDiskTypeName zoneName = ProjectZoneDiskTypeName.parse(trimUrl(diskType.getSelfLink()));
136-
assertThat(zoneName.getDiskType()).isNotNull();
137-
assertThat(zoneName.getZone()).isNotNull();
136+
assertThat(diskType.getRegion() != null || diskType.getZone() != null).isTrue();
137+
if (diskType.getRegion() != null) {
138+
ProjectRegionDiskTypeName zoneName = ProjectRegionDiskTypeName
139+
.parse(trimUrl(diskType.getSelfLink()));
140+
assertThat(zoneName.getDiskType()).isNotNull();
141+
assertThat(zoneName.getRegion()).isNotNull();
142+
} else {
143+
ProjectZoneDiskTypeName zoneName = ProjectZoneDiskTypeName
144+
.parse(trimUrl(diskType.getSelfLink()));
145+
assertThat(zoneName.getDiskType()).isNotNull();
146+
assertThat(zoneName.getZone()).isNotNull();
147+
}
138148
assertThat(diskType.getCreationTimestamp()).isNotNull();
139149
assertThat(diskType.getDescription()).isNotNull();
140150
assertThat(diskType.getValidDiskSize()).isNotNull();

0 commit comments

Comments
 (0)